Summary: | Remove CGI::scrolling_list from C4:Budgets | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Templates | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, paul.poulain |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 766 | ||
Attachments: |
Proposed Patch
Signed off Patch proposed patch (passed QA) |
Description
Colin Campbell
2011-04-13 16:15:26 UTC
Created attachment 3913 [details] [review] Proposed Patch Colin could you provide more info on how to properly test these changes? The only meaningful test is to ensure the fund selection box in order creation is working. As noted in the patch the dropdowns for sort1/sort2 do not appear to be activated in the standard version. Created attachment 4356 [details] [review] Signed off Patch Created attachment 4933 [details] [review] proposed patch (passed QA) QA comment: * after applying the patch, I made grep -R on the 3 removed sub GetBudgetPermDropbox, GetBudgetSortDropbox, GetBudgetPeriodsDropbox they don't appear anywhere anymore * changes made to GetAuthvalueDropbox are also consistents * I've tested the scripts modified by this patch (aqbugetperiod, addorderiso2709,...), no problem detected. passed QA Pushed, please test well There have been no further reports of problems so I am marking this bug resolved. |