As noted in bug 766 3.2 imported a lot of new instances of CGI::scrolling_list into C4::Budgets. They should be fixed. Most of them are not used by any other code so should be cleaned out.
Created attachment 3913 [details] [review]
Colin could you provide more info on how to properly test these changes?
The only meaningful test is to ensure the fund selection box in order creation is working. As noted in the patch the dropdowns for sort1/sort2 do not appear to be activated in the standard version.
Created attachment 4356 [details] [review]
Signed off Patch
Created attachment 4933 [details] [review]
proposed patch (passed QA)
* after applying the patch, I made grep -R on the 3 removed sub GetBudgetPermDropbox, GetBudgetSortDropbox, GetBudgetPeriodsDropbox they don't appear anywhere anymore
* changes made to GetAuthvalueDropbox are also consistents
* I've tested the scripts modified by this patch (aqbugetperiod, addorderiso2709,...), no problem detected.
Pushed, please test well
There have been no further reports of problems so I am marking this bug resolved.