Summary: | doc-head-open.inc not found. | ||
---|---|---|---|
Product: | Koha | Reporter: | Rudy Hinojosa <rudyhinojosa2007> |
Component: | I18N/L10N | Assignee: | Frédéric Demians <f.demians> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, robin, saminium, tom |
Version: | 3.6 | ||
Hardware: | PC | ||
OS: | Linux | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 6205 - if an include doesn't exist, fall back to en
Signed-off patch |
Description
Rudy Hinojosa
2011-04-19 04:30:26 UTC
This is when running the upgrade? I upgraded fine this morning, are you running the installer in french? Thanks for the report, fixed now, please test and mark the bug resolved You guys are awesome! This was my first experience reporting a bug and was amazed at your response time and how the bug number appeared on my screen when i did the git pull command... Super work guys. thanks. I have the bug My running OS is debian 6.0.1 running on virtual box koha 3.2 Software error: Template process failed: file error - doc-head-open.inc: not found at /usr/share/koha/lib/C4/Templates.pm line 119. For help, please send mail to the webmaster (webmaster@debmaker32), giving this error message and the time and date of the error. What version are you trying to upgrade to? And what language are you running in? C4/Templates.pm does not in exist in version 3.2 so I am guessing you are trying to upgrade to 3.4.0? I can not recreate the bug here, so I need more information *** Bug 6270 has been marked as a duplicate of this bug. *** This can be a sign that the database is set to use a language that isn't installed. This is still an issue, I just managed to reproduce it by accident. The problem I'm seeing is that if the KohaOpacLanguage cookie is set, the system (including the staff client) will attempt to use it, even if that language doesn't actually exist in the system. This causes things to explode. I ran into this error when installing 3.4.4. I only ran into it on the OPAC, however. The Staff client works but the OPAC does not. The error does get logged: [Wed Sep 07 12:27:57 2011] [error] [client 10.41.63.254] [Wed Sep 7 12:27:57 2011] opac-main.pl: Template process failed: file error - doc-head-open.inc: not found at /shared/kohapprd/soft/lib/C4/Templates.pm line 119. This is (or should be) all in English. Created attachment 5528 [details] [review] Bug 6205 - if an include doesn't exist, fall back to en If a language that doesn't exist gets accessed, then it will fall back to en for the templates, but not for the includes, so everything still dies. This allows the process to work in this case too. This patch should address another set of issues that can cause this. Now that I try to, I can't reproduce this. I checked my cookie and my db say de-DE, but deleted the templates. I am shown the English templates for OPAC and staff. Created attachment 5576 [details] [review] Signed-off patch I confirm the bug and the solution. This issue occurs when templates are partially translated. The main template (.tt) is found for a specific language, so this language is returned by themetemplate. But in the main template, some include files (subtemplates) are referenced that can very well not exist if the translation process had failed to generate them. This kind of failure is reported by 'translate' script. It's very easy to miss it, but it's the translator responsibility to check it. We also have some custom templates where we just "translate" one or two files (to make upgrades easier) and this allows the includes to not have to be copied across, they'll fall back to the default. Working in production, no harm patch, pushed Included in 3.6 prior to 3.6.5. |