Bug 6234

Summary: Links on hold ratios report broken
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on: 6241    
Bug Blocks: 5917    
Attachments: proposed patch
Corrected patch

Description Katrin Fischer 2011-04-21 13:59:42 UTC
The links in hold ratios report are broken.
Comment 1 Katrin Fischer 2011-04-21 15:26:49 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2011-04-21 15:57:01 UTC
A couple of fixes required:

1. I think an instance was missed on /cgi-bin/koha/circ/waitingreserves.pl. The "holds over" tab still doesn't have working links.
2. I think the change to reserveratios.tt removing <p class="ratiolimit"> from the ratio is incorrect. This is unrelated to the TT conversion. It was added as part of Bug 3130. From the commit message, "I also added the hold ratio to a column display, with a jquery tweak to put it in the ratio input box on click."
Comment 3 Katrin Fischer 2011-04-21 17:38:35 UTC
Created attachment 3979 [details] [review]
Corrected patch

Made changes suggested by Owen.
Comment 4 Chris Cormack 2011-04-21 19:09:40 UTC
Pushed please test