Summary: | Guided reports wizard 'Build new' brings up empty page | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | Liz Rea <wizzyrea> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, magnus, nengard, nunyo.lopez, wizzyrea |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/reports/guided_reports.pl?phase=Build new | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5917 | ||
Attachments: |
Proposed patch
Followup - removes the commented out old bad code Signed-off patch |
Description
Katrin Fischer
2011-04-24 15:53:42 UTC
*** Bug 6307 has been marked as a duplicate of this bug. *** I'm thinking that this is a tt issue, do we have any other way to get to this page at this time? Nicole Created attachment 4206 [details] [review] Proposed patch To test: Click More -> Reports, you should see the welcome page and be able to step through creating the report. Note: I accidentally left in the commented out code that is incorrect. I'll attach a followup that removes it. Created attachment 4207 [details] [review] Followup - removes the commented out old bad code To test: More -> Reports, you should be able to see the guided reports and build one from scratch. (though nothing has functionally changed) Sorry, the patch does not apply for me: git am -i3u bug6258.patch Applying: Bug 6258 Followup - Removing the bad code that I accidentally left in. fatal: sha1 information is lacking or useless (reports/guided_reports.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6258 Followup - Removing the bad code that I accidentally left in. PS. The first patch, with the commented line left in, applies nicely and works as advertised... Looks like the two patches just need to be squashed. Created attachment 4232 [details] [review] Signed-off patch Squashed the two patches and signed off. Tested, confirmed, works. Marking as Passed QA. Pushed, please test and mark resolved Reports > Build new displays as expected, I'm marking this fixed. However, it looks like some of the options in step 5 and 6 are not displaying properly. I'll investigate some more and create a new bug report if it's needed. The problem with steps 5 and 6 is now Bug 6417 and I have submitted a patch. |