|Summary:||Guided reports wizard 'Build new' brings up empty page|
|Product:||Koha||Reporter:||Katrin Fischer <katrin.fischer>|
|Component:||Reports||Assignee:||Liz Rea <wizzyrea>|
|Status:||CLOSED FIXED||QA Contact:||Bugs List <koha-bugs>|
|Priority:||PATCH-Sent (DO NOT USE)||CC:||chris, koha.sekjal, magnus, nengard, nunyo.lopez, wizzyrea|
|Change sponsored?:||---||Patch complexity:||---|
|Documentation contact:||Documentation submission:|
|Text to go in the release notes:||Version(s) released in:|
|Bug Depends on:|
Followup - removes the commented out old bad code
Description Katrin Fischer 2011-04-24 15:53:42 UTC
Trying to 'Build new' report using Guided Reports Wizard opens empty page.
Comment 1 Owen Leonard 2011-05-05 12:15:24 UTC
*** Bug 6307 has been marked as a duplicate of this bug. ***
Comment 2 Nicole C. Engard 2011-05-13 17:18:12 UTC
I'm thinking that this is a tt issue, do we have any other way to get to this page at this time? Nicole
Comment 3 Liz Rea 2011-05-20 20:11:12 UTC Comment hidden (obsolete)
Created attachment 4206 [details] [review] Proposed patch To test: Click More -> Reports, you should see the welcome page and be able to step through creating the report. Note: I accidentally left in the commented out code that is incorrect. I'll attach a followup that removes it.
Comment 4 Liz Rea 2011-05-20 20:14:41 UTC Comment hidden (obsolete)
Created attachment 4207 [details] [review] Followup - removes the commented out old bad code To test: More -> Reports, you should be able to see the guided reports and build one from scratch. (though nothing has functionally changed)
Comment 5 Magnus Enger 2011-05-21 12:34:08 UTC
Sorry, the patch does not apply for me: git am -i3u bug6258.patch Applying: Bug 6258 Followup - Removing the bad code that I accidentally left in. fatal: sha1 information is lacking or useless (reports/guided_reports.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6258 Followup - Removing the bad code that I accidentally left in.
Comment 6 Magnus Enger 2011-05-21 12:42:35 UTC
PS. The first patch, with the commented line left in, applies nicely and works as advertised...
Comment 7 Owen Leonard 2011-05-23 13:25:07 UTC
Looks like the two patches just need to be squashed.
Comment 8 Owen Leonard 2011-05-23 13:29:34 UTC
Created attachment 4232 [details] [review] Signed-off patch Squashed the two patches and signed off.
Comment 9 Ian Walls 2011-05-25 21:00:46 UTC
Tested, confirmed, works. Marking as Passed QA.
Comment 10 Chris Cormack 2011-05-25 23:29:51 UTC
Pushed, please test and mark resolved
Comment 11 Magnus Enger 2011-05-26 07:07:49 UTC
Reports > Build new displays as expected, I'm marking this fixed. However, it looks like some of the options in step 5 and 6 are not displaying properly. I'll investigate some more and create a new bug report if it's needed.