Summary: | subscription table sorter in the opac | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | cgi-bin/koha/opac-serial-issues.pl?selectview=full&biblionumber=4038 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed fix
Revised fix signed off patch proposed patch (passed QA) proposed patch (passed QA) |
Description
Nicole C. Engard
2011-05-05 13:24:48 UTC
Created attachment 4039 [details] [review] Proposed fix The sorter works on the current year of subscription only; if a previous year is selected, the tablesorter does not appear. It seems to me more likely that someone would be going into the full history for older issues than more current ones, so I'm marking this as Failed QA until such time as the tablesorter can be added to previous years as well as current. Created attachment 4195 [details] [review] Revised fix Created attachment 4237 [details] [review] signed off patch Created attachment 4947 [details] [review] proposed patch (passed QA) QA comment * patch "Revised fix" is obsolete by "signed-off patch", i've discarded it * it's a small patch, that does what he's expected to do, and it deals gracefully with dateformat (even if "dateFormat : 'uk' could have been written "dateFormat: 'dd/mm/yyyy' I think) Marking "passed QA" Created attachment 4948 [details] [review] proposed patch (passed QA) (made a mistake in my previous upload) Patch pushed, please test |