6309 – subscription table sorter in the opac

Bug 6309 - subscription table sorter in the opac

Summary: subscription table sorter in the opac

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	OPAC (show other bugs)
Version:	Main
Hardware:	All All

Importance:	PATCH-Sent (DO NOT USE) enhancement
Assignee:	Owen Leonard
QA Contact:	Bugs List

URL:	cgi-bin/koha/opac-serial-issues.pl?se...
Keywords:

Depends on:
Blocks:

Reported:	2011-05-05 13:24 UTC by Nicole C. Engard
Modified:	2012-10-25 23:09 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed fix (1.75 KB, patch) 2011-05-05 13:34 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Revised fix (1.46 KB, patch) 2011-05-19 19:38 UTC, Owen Leonard	Details \| Diff \| Splinter Review
signed off patch (1.48 KB, patch) 2011-05-23 19:35 UTC, Nicole C. Engard	Details \| Diff \| Splinter Review
proposed patch (passed QA) (1.48 KB, patch) 2011-08-10 15:37 UTC, Paul Poulain	Details \| Diff \| Splinter Review
proposed patch (passed QA) (1.52 KB, patch) 2011-08-10 15:38 UTC, Paul Poulain	Details \| Diff \| Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nicole C. Engard 2011-05-05 13:24:48 UTC

It would be nice to have a table sorter for the full subscription detail page in the OPAC. A sorter that lets you sort any of the columns.

Comment 1 Owen Leonard 2011-05-05 13:34:03 UTC Comment hidden (obsolete)

Created attachment 4039 [details] [review]
Proposed fix

Comment 2 Ian Walls 2011-05-10 20:48:12 UTC

The sorter works on the current year of subscription only; if a previous year is selected, the tablesorter does not appear.  It seems to me more likely that someone would be going into the full history for older issues than more current ones, so I'm marking this as Failed QA until such time as the tablesorter can be added to previous years as well as current.

Comment 3 Owen Leonard 2011-05-19 19:38:49 UTC Comment hidden (obsolete)

Created attachment 4195 [details] [review]
Revised fix

Comment 4 Nicole C. Engard 2011-05-23 19:35:25 UTC Comment hidden (obsolete)

Created attachment 4237 [details] [review]
signed off patch

Comment 5 Paul Poulain 2011-08-10 15:37:56 UTC Comment hidden (obsolete)

Created attachment 4947 [details] [review]
proposed patch (passed QA)

QA comment

* patch "Revised fix" is obsolete by "signed-off patch", i've discarded it
* it's a small patch, that does what he's expected to do, and it deals gracefully with dateformat (even if "dateFormat : 'uk' could have been written "dateFormat: 'dd/mm/yyyy' I think)

Marking "passed QA"

Comment 6 Paul Poulain 2011-08-10 15:38:58 UTC

Created attachment 4948 [details] [review]
proposed patch (passed QA)

(made a mistake in my previous upload)

Comment 7 Chris Cormack 2011-08-14 08:29:24 UTC

Patch pushed, please test