Summary: | DB changes needed for Hourly Circulation | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Circulation | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | CLOSED WONTFIX | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jcamins, jonathan.druart, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 8129, 8154 | ||
Bug Blocks: | 5549, 6431 | ||
Attachments: | Bug 6430 - DB changes needed to support hourly circ |
Description
Chris Cormack
2011-05-31 01:28:56 UTC
Created attachment 4311 [details] [review] Bug 6430 - DB changes needed to support hourly circ Changing columns to datetime instead of date Squashed commit of the following: commit ccf37880eaf660685d439b000298dcc025e78b6e Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Thu May 26 12:06:24 2011 +1200 Bug 5549 backing out of decision to change the name of the colums commit 2e326fdec7d768fe93d41e93abf3ca665a363791 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Tue May 24 14:31:26 2011 +1200 Bug 5549 : Starting work on hourly loans, changing issues table Per conversation with rangi, this patch has already been applied to the branch for bug 5579. Marking this bug RESOLVED-WONTFIX. Hummm. I don't understand how this patch have been pushed into master: commit e56c4b249d9ac66e05054f916560a0f7bea9a194 Author: Chris Cormack <chrisc@catalyst.net.nz> AuthorDate: Tue May 31 13:35:14 2011 +1200 Commit: Chris Cormack <chrisc@catalyst.net.nz> CommitDate: Tue Mar 20 13:28:52 2012 +1300 Bug 6430 - DB changes needed to support hourly circ So, it is in master since Mar 20 2012. It breaks my patch Bug 6751: I compare the issue.returndate and C4::Dates->new(); Before this patch, it was consistent, comparing date and date. But now, issue.returndate is never equal to C4::Dates->new(); (compare datetime and date). I think my patch is not the only one encountering this problem. With a quick search, I think at least these lines are impacted: C4/Members.pm: if ($it->{'issuedate'} eq $today) { circ/circulation.pl: if ( $todaysdate eq $it->{'issuedate'} or $todaysdate eq $it->{'lastreneweddate'} ) { Did I misunderstand something (and then I need my week-end break now!) or does this patch introduce side effects ? |