branch is on git.koha-community.com koha-biblibre.git wip/remove_items
Pushed to new/bug_5579 This needs a decent amount of testing, it does improve performance a lot but we need to make sure we don't lose any data
Revised patch series submitted for inclusion in 3.4. Patches can be pulled from the bug5579 branch of git://git.librarypolice.com/git/koha-galen.git.
Created attachment 3780 [details] [review] bug 5579 : Fixes several exports to embed items This patche fixes exports pages from both OPAC and Intranet to embed items, as before.
Created attachment 3797 [details] [review] Fixes ISBD display This (tiny) patch fixes ISBD display (ie: show items)
Created attachment 3812 [details] [review] Initials commits (hdl and galen) can be found in branches
Created attachment 3826 [details] [review] signed off patches set It seems good for me - maybe another person could sign off it too.
It is pushed to new/enh/bug_5579 I would like another person to test that branch and report it is ok, so it can be merged.
I think I found a problem here: * Test 1: While on the master branch i run: bulkmarcimport.pl -b -file records.mrc -v -n 1000 -d to get some records into Koha. I then do: git checkout origin/new/enh/bug_5579 git checkout -b bug5579so and then run: remove_items_from_biblioitems.pl --run rebuild-zebra.pl -b -r -v This seems to work fine, so far. * Test 2 While still on the same branch i created above, I run bulkmarcimport.pl -b -file records.mrc -v -n 1000 -d again to mimic importing some more records in to Koha - this seems to work fine. But when i try to run: rebuild-zebra.pl -b -r -v i get this error: exporting biblio ==================== 1Can't call method "field" on an undefined value at /home/magnus/scripts/kohanor32/C4/Biblio.pm line 2656.
nice catch. I bet it comes out of the BatchAdd Item call in the bulkmarcimport. which has not been upgraded.
I removed the records I imported in test 2 above and tried to 1. add a record through normal cataloguing 2. add a record through the web UI (stage for import) and none of these had the same problem when running rebuild_zebra.pl. Guess that strengthens the suspicion about bulkmarcimport.pl being the culprit.
Patches pushed to new/enh/bug_5579 This has been tested by Liz at NEKLS too, im doing some final testing, and then I will merge to master
Pushed to master, please test
Created attachment 4264 [details] [review] Signed off patch -- further prettying of this script
Marking the 'further prettying' patch as Passed QA.
Pushed, please test