Summary: | No log generated if Action set to All or Modify or Delete | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | Transaction logs | Assignee: | Janusz Kaczmarek <januszop> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, katrin.fischer, koha.sekjal, magnus, mjr, paul.poulain |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed patch
Signed-off patch Bug 6460: alternative fix, updating template and script instead of C4::Log - a bit rushed Bug 6460: alternative fix, updating template and script instead of C4::Log Bug 6460: alternative fix, updating template and script instead of C4::Log [Signed Off] Bug 6460: alternative fix, updating template and script instead of C4::Log |
Description
Janusz Kaczmarek
2011-06-04 23:14:08 UTC
Created attachment 4359 [details] [review] Proposed patch BTW, the patch applies to 3.2.9 too. Before applying the patch, no results are shown when Action is set to All, Modify or Delete in Tools > Log Viewer. After applying the patch results are shown for all of the Actions, including the ones mentioned above. Signing off! Created attachment 4478 [details] [review] Signed-off patch QA comment I think this patch should be rejected: the diagnostic is correct (Actions are logged as MODIFY, DELETE etc., whereas template viewlog.t* uses mod, del and passes it to viewlog.pl) so, why not fix the template to pass MODIFY, DELETE,... It would be a better solution than using LIKE. Also note that your patch prevent to change the select to have a "MULTIPLE", that would be a handy feature. Created attachment 5546 [details] [review] Bug 6460: alternative fix, updating template and script instead of C4::Log - a bit rushed Created attachment 5560 [details] [review] Bug 6460: alternative fix, updating template and script instead of C4::Log Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer. (In reply to comment #7) > Created attachment 5560 [details] [review] > Bug 6460: alternative fix, updating template and script instead of C4::Log > > Add some test cases and fix a bug in C4::Log found by in review. > Thanks-to: Katrin Fischer. And fixing that bug also seems to have fixed the fix. Please hold off for now while I recode it. Created attachment 5569 [details] [review] Bug 6460: alternative fix, updating template and script instead of C4::Log Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer. Created attachment 5570 [details] [review] [Signed Off] Bug 6460: alternative fix, updating template and script instead of C4::Log Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer. Signed-off-by: Liz Rea <lrea@nekls.org> Passes test, interface works as expected. Signed-off-by: Liz Rea <lrea@nekls.org> Changes template instead of script. Also adds a test case, which is double-plus good. Marking as Passed QA Pushed, I agree, bonus points for the test case |