| Summary: | Checkout slip should be more informative, especially for single-library catalogs | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jesse Weaver <pianohacker> |
| Component: | Circulation | Assignee: | Jesse Weaver <pianohacker> |
| Status: | CLOSED WONTFIX | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, nengard, paul.poulain, wizzyrea |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 7001 | ||
| Attachments: | Bug 6485 - Checkout slip should be more useful | ||
|
Description
Jesse Weaver
2011-06-08 20:53:48 UTC
Created attachment 4433 [details] [review] Bug 6485 - Checkout slip should be more useful This patch makes the following improvements to the checkout slip: * Does not show the branchname if it is the same as the global LibraryName, which is useful for single-library catalogs. * Shows branchaddress* information. This is wrapped in a <div> with class .slip-address-info, making it easy to disable with intranetuserjs... * ... which has been added to the checkout slip. One thing I don't understand here is
<script language="javascript">
function printThenClose() {
+ return;
window.print();
window.close();
}
</script>
Why the return ? (I don't fully grok javascript so it might just be me being dense)
QA comment:
Chris, you're not dense:
function printThenClose() {
+ return;
window.print();
window.close();
}
means window.print & window.close will never be reached.
2 options :
* it's was for testing purposes & forgotten to be removed (my bet)
* .print & .close can be removed
Anyway, failed QA !
This patch may become moot if 7001 passes. |