Bug 6485 - Checkout slip should be more informative, especially for single-library catalogs
Summary: Checkout slip should be more informative, especially for single-library catalogs
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Jesse Weaver
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 7001
  Show dependency treegraph
 
Reported: 2011-06-08 20:53 UTC by Jesse Weaver
Modified: 2014-12-07 20:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 6485 - Checkout slip should be more useful (2.62 KB, patch)
2011-06-08 22:22 UTC, Jesse Weaver
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Weaver 2011-06-08 20:53:48 UTC
The checkout slip is currently rather informative, and could use a few improvements:

* The branchname should not be displayed if it is the same as the global LibraryName.
* The address should be displayed on the slip. This more closely matches the behavior of other ILSes.
Comment 1 Jesse Weaver 2011-06-08 22:22:31 UTC
Created attachment 4433 [details] [review]
Bug 6485 - Checkout slip should be more useful

This patch makes the following improvements to the checkout slip:

* Does not show the branchname if it is the same as the global
LibraryName, which is useful for single-library catalogs.
* Shows branchaddress* information. This is wrapped in a <div> with
class .slip-address-info, making it easy to disable with
intranetuserjs...
* ... which has been added to the checkout slip.
Comment 2 Chris Cormack 2011-09-12 22:25:05 UTC
One thing I don't understand here is

<script language="javascript">
     function printThenClose() {
+        return;
         window.print();
         window.close();
     }
 </script>

Why the return ? (I don't fully grok javascript so it might just be me being dense)
Comment 3 Paul Poulain 2011-10-06 16:36:22 UTC
QA comment:

Chris, you're not dense:
     function printThenClose() {
+        return;
         window.print();
         window.close();
     }

means window.print & window.close will never be reached.

2 options :
* it's was for testing purposes & forgotten to be removed (my bet)
* .print & .close can be removed

Anyway, failed QA !
Comment 4 Liz Rea 2012-01-27 21:54:21 UTC
This patch may become moot if 7001 passes.
Comment 5 Liz Rea 2012-05-31 14:40:04 UTC
the enhancements introduced by bug 7001 should fix this issue.