Created attachment 4448 [details]
opac with hyphens (xslt off)
Created attachment 4449 [details]
order of fields in opac
Created attachment 4450 [details]
order of fields in opac (marc view)
Attaching MARC records for this kind of thing makes checking it easier, although I'm sure I can make one up easily in this case :) Staff client without XSLT: looks nice, uses '--' to split up Staff client with XSLT: they are all joined up, no spaces, which is ugly. OPAC without XSLT: looks nice, uses '--' to split up OPAC with XSLT: all joined up, no spaces, ugly. I'll check out the order thing separately, probably as a patch on top of one that fixes the layout. Created attachment 5235 [details] [review] Bug 6496 - tidy the display of 710 fields on XSLT This puts '--' between 710$b fields, and replaces the '.' with a '; ' if there are additional authors. Oh, this patch doesn't address the ordering thing. Created attachment 5343 [details] [review] [SIGNED-OFF] Bug 6496 - tidy the display of 710 fields on XSLT This puts '--' between 710$b fields, and replaces the '.' with a '; ' if there are additional authors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> A follow up is still necessary for the ordering, but this first patch does fix the display aspect so I have signed off on it. Nicole Created attachment 5397 [details]
Before shot, showing the current (incorrect) ordering display on the OPAC
Created attachment 5399 [details]
After shot, showing the new (correct) ordering display on the OPAC
Created attachment 5400 [details] [review] Bug 6496 - correct the order of the author display in the OPAC This sets the order to be 100,110,111,700,710,711, rather than 100,700,110,710,... like it was. Basically, it's a port of the way it's done in the staff client. As such, it should be able to handle a lot more than it could previously, including relator codes. Actually, a comment I failed to add to the commit...it doesn't display it in numerical order, it displays it in the order in the MARC, which typically is the correct order. Let me know if this is an issue and I'll puzzle out making it sort. Also, this is intended to go on top of the signed-off patch. If that's not done, it probably won't apply. Created attachment 5409 [details] [review] Bug 6496 - correct the order of the author display in the OPAC This sets the order the fields are displayed in to be as it is in the MARC (typically numerical order), rather than 100,700,110,710,... like it was. Basically, it's a port of the way it's done in the staff client. As such, it should be able to handle a lot more than it could previously, including relator codes. (replaces the previous commit, just removing an erronious comment and making the commit message more accurate) Created attachment 5451 [details]
screenshot of opac
I applied both patches and tried cataloging a record with 100, 110, 700 and 710. I am not sure, I did it right. The order seems right to me, it's 100, 110, 700, 710.
I think an additional space is missing after 110, to make it _;_ consistently.
It's always inserting '; ', which I think was taken from the staff client implementation (although I'd have to double check that.) It has no special handling of the 110 field. This suggests to me that all your other fields have a trailing space as part of their record. I'm not sure what the cataloguing spec says here, should we put a trailing space in, or not? Are the records expected to have one? It's a very easy change to add a space. I added authorities and linked them in cataloging. I checked my authorities and the record and can't find any trailing spaces. Hmm, now I think of it, my records won't have trailing spaces, but are not done with authorities. Are all of yours authorities, or just the 110? Is the 710 done with authorities too? Can you add a 711 field, I want to see if the 710 shows the same behaviour (as it follows exactly the same codepath as the 110.) Robin, Does this obsolete my signed off patch or is it a follow up? Nicole (In reply to comment #15) > Created attachment 5409 [details] [review] > Bug 6496 - correct the order of the author display in the OPAC > > This sets the order the fields are displayed in to be as it is in the > MARC (typically numerical order), rather than 100,700,110,710,... like > it was. > > Basically, it's a port of the way it's done in the staff client. As > such, it should be able to handle a lot more than it could previously, > including relator codes. > > (replaces the previous commit, just removing an erronious comment and > making the commit message more accurate) It's a followup, the signed-off one does the separator characters, this one does the ordering. [SIGNED-OFF] Bug 6496 - tidy the display of 710 fields on XSLT Apply? [yn] y Applying: Bug 6496 - tidy the display of 710 fields on XSLT Bug 6496 - correct the order of the author display in the OPAC Apply? [yn] y Applying: Bug 6496 - correct the order of the author display in the OPAC error: patch failed: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl:128 error: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl: patch does not apply Patch failed at 0001 Bug 6496 - correct the order of the author display in the OPAC I can confirm that this follow up still does not apply: nengard@debian:~/kohaclone$ git bz apply 6496 Bug 6496 - authors appearing incorrectly in OPAC and Staff Client [SIGNED-OFF] Bug 6496 - tidy the display of 710 fields on XSLT Apply? [yn] n Bug 6496 - correct the order of the author display in the OPAC Apply? [yn] y Applying: Bug 6496 - correct the order of the author display in the OPAC error: patch failed: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl:128 error: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl: patch does not apply Patch failed at 0001 Bug 6496 - correct the order of the author display in the OPAC When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-6496---correct-the-order-of-the-author-display-6K4Z4g.patch nengard@debian:~/kohaclone$ Hi Nicole, only a note: git bz apply does not use the -3 option. Sometimes the patch will apply when you do a git am -is3 /tmp.... No such luck: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6496 - correct the order of the author display in the OPAC Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl Failed to merge in the changes. Patch failed at 0001 Bug 6496 - correct the order of the author display in the OPAC When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ Created attachment 7419 [details] [review] Bug 6496 - correct the order of the author display in the OPAC This sets the order the fields are displayed in to be as it is in the MARC (typically numerical order), rather than 100,700,110,710,... like it was. Basically, it's a port of the way it's done in the staff client. As such, it should be able to handle a lot more than it could previously, including relator codes. (replaces the previous commit, just removing an erronious comment and making the commit message more accurate) Conflicts: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl Rebased so that it applies. Created attachment 7479 [details] [review] Bug 6496 - tidy the display of 710 fields on XSLT This puts '--' between 710$b fields, and replaces the '.' with a '; ' if there are additional authors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 7480 [details] [review] Bug 6496 - correct the order of the author display in the OPAC This sets the order the fields are displayed in to be as it is in the MARC (typically numerical order), rather than 100,700,110,710,... like it was. Basically, it's a port of the way it's done in the staff client. As such, it should be able to handle a lot more than it could previously, including relator codes. (replaces the previous commit, just removing an erronious comment and making the commit message more accurate) Conflicts: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> QA comment: XSLT changes only, MARC21 specific, nothing to say passed QA There have been no further reports of problems so I am marking this bug resolved. |
Created attachment 4447 [details] opac with dots In the staff client if the additional author (7xx) has multiple parts it's putting dots in between the parts if XSLT is on and hyphens if it's off. It's easier to read with the hyphens. In the OPAC there are dots and no spaces and it's all smooched up. See attached. It should probably be hyphens or spaces instead of dots. Also some strangeness is happening with the order of authors. In the staff client when you have XSLT on additional authors are clearly on another line (easy to read) but in the OPAC, things aren't coming through right. In the OPAC the 100s are first then the 700s and then the 110s and then the 710s ... it should be all 1xxs and then all 7xxs (preferrably with the relator code showing so you know if it's an editor or illustrator) - at the very least the order should be fixed in this way. My screenshots show this all for you on my very bad marc record :)