In the checkout page there is for example the message:
Attention:
Fees & Charges: Patron has Outstanding fees & charges of 2.00. <Make payment>
This message can vary if there is some other information which might prevent the checkout.
I propose that we include that same thing to the page Details (maybe under the alternate address info). I looked into this already but it looked difficult to implement because at the moment there is no abstraction in the code which serves the Check out page. And the solution which I see as doable in a short period of time (4 hours) is to just copy paste the code from circulation.pl. Otherwise it could take day(s) to refactor circulation.pl to use some generic functions to get the info. And then after that do the code which shows the info in the Details page... Refactoring is what I would go with but... We will see.
I like also the idea of having the red indication in the fines tab and it could also have the amount owed in the title.
Please, see also the bug 3153. Maybe we could refactor the code so that we could have the alert Attention: Fees & Charges: Patron has Outstanding fees & charges of 2.00. <Make payment> in many places shown easily. *** Bug 13652 has been marked as a duplicate of this bug. *** I really like Hene's idea of having the amount on the tab or at least some sign of existing fines as that would match the other tabs. Created attachment 94601 [details] [review] Bug 6508: Add balance to `Fines & Charges` tab Well.. this patch adds the detail into the tab as requested.. however I'm really not sure what the point of that tab is at all now.. all it displays when clicked is this exact information.. did it show a table of charges in there at some point perhaps? I agree with Martin that this doesn't add any additional information. I have another suggestion: We could only show the tab when there are any fines and charges. This way, for libraries not using fines it will be a nicer display and the tab appearing will have a meaning. I've also noticed that we only show the tab on details, but not on the checkouts tab. (In reply to Katrin Fischer from comment #8) > I agree with Martin that this doesn't add any additional information. > Does this tab really needs to be kept ? As Katrin said, it the only page where it's display, and we have and alert at the top of the page showing the total amount of charges, with 2 useful action buttons. Isn't that enough ? > I have another suggestion: We could only show the tab when there are any > fines and charges. > This way, for libraries not using fines it will be a nicer display and the > tab appearing will have a meaning. > +1 if the tab is kept ! +1 to just getting rid of it. Created attachment 98786 [details] [review] Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 98787 [details] [review] Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Created attachment 98809 [details] [review] Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 98810 [details] [review] Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98972 [details] [review] Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 98973 [details] [review] Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98974 [details] [review] Bug 6508: (follow-up) Remove dependency on jquery for check in templates Should work as before with the test plan from the second patch. But removes the added jQuery display control code in favor of checking if fines is set on template level. For several patrons with and without fines and with credits: - Check the Fines & Charges only display when there is something to see I am not in favor of relying on JavaScript here - so I am proposing a follow-up that uses checks on TT level instead. Could you have a look Aleisha or David? Created attachment 99004 [details] [review] Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 99005 [details] [review] Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind <david@davidnind.com> Created attachment 99006 [details] [review] Bug 6508: (follow-up) Remove dependency on jquery for check in templates Should work as before with the test plan from the second patch. But removes the added jQuery display control code in favor of checking if fines is set on template level. For several patrons with and without fines and with credits: - Check the Fines & Charges only display when there is something to see Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Katrin Fischer from comment #18) > I am not in favor of relying on JavaScript here - so I am proposing a > follow-up that uses checks on TT level instead. Could you have a look > Aleisha or David? Looks good Katrin Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x Thank you all. |
Created attachment 4487 [details] Screenshot of Patron Details Tabs in Staff Client On the patron details page in the staff client,if a patron has something checked out or on hold, it shows how many items in the check out or hold tab at the bottom of the page. It does not, however, show any indication of an amount of fines or charges unless you click on it. Please refer to the attached screenshot. Proposals for fix: 1. Have the "total due" or the number of fines that have been assessed show in the tab before the words "Fines and charges", just as a number shows before checkouts and holds? 2. Make the tab to be "hot" in some way, like if a patron owes fines, the font changes to bold red for that tab?