Summary: | AllowHoldPolicyOverride not working | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Hold requests | Assignee: | Srdjan Jankovic <srdjan> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cnighswonger, gmcharlt, koha.sekjal, paul.poulain |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
patch
[SIGNED-OFF] bug_6770: removed doubled override increment when using AllowHoldPolicyOverride patch |
Description
Nicole C. Engard
2011-08-24 18:56:16 UTC
Created attachment 5313 [details] [review] patch Created attachment 5347 [details] [review] [SIGNED-OFF] bug_6770: removed doubled override increment when using AllowHoldPolicyOverride Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Removes duplicate logic, and overall simplifies a very complex and unpleasant conditional. In my testing, this works in a variety of "cannot place hold" situations. Marking as Passed QA. Pushed, please test This does not apply cleanly to 3.4.x. If it should, please rebase against the 3.4.x branch and resubmit with [3.4.x] in the subject line. Created attachment 5819 [details] [review] patch Sorry, I missed to put [3.4.x] in the subject line This doesn't need a second signoff does it? Owen, right, this has just been updated for 3.4.x. Chris N, this should apply now. fixed in 3.6 Chris_n, can you take care of it in 3.4 ? (In reply to comment #10) > fixed in 3.6 Chris_n, can you take care of it in 3.4 ? Done already. tnx Marking patch pushed since this was bumped back to 3.4.x. Please test and close. There have been no further reports of problems so I am marking this bug resolved. |