When a patron has more than 5 holds staff was previously able to place holds for the patron over-riding the 5 hold limit (with the AllowHoldPolicyOverride pref set to allow). I find that I am unable to do that at this time. I know I was previously able to over-ride the 5 hold limit for patrons.
Created attachment 5313 [details] [review]
Created attachment 5347 [details] [review]
[SIGNED-OFF] bug_6770: removed doubled override increment when using AllowHoldPolicyOverride
Signed-off-by: Nicole C. Engard <firstname.lastname@example.org>
Removes duplicate logic, and overall simplifies a very complex and unpleasant conditional. In my testing, this works in a variety of "cannot place hold" situations. Marking as Passed QA.
Pushed, please test
This does not apply cleanly to 3.4.x. If it should, please rebase against the
3.4.x branch and resubmit with [3.4.x] in the subject line.
Created attachment 5819 [details] [review]
Sorry, I missed to put [3.4.x] in the subject line
This doesn't need a second signoff does it?
Owen, right, this has just been updated for 3.4.x. Chris N, this should apply now.
fixed in 3.6 Chris_n, can you take care of it in 3.4 ?
(In reply to comment #10)
> fixed in 3.6 Chris_n, can you take care of it in 3.4 ?
Done already. tnx
Marking patch pushed since this was bumped back to 3.4.x. Please test and close.
There have been no further reports of problems so I am marking this bug resolved.