Bug 6817

Summary:	In overdue.pl, downloading the overdues as a file ignores the filters if the page isn't in english.
Product:	Koha	Reporter:	Frédérick Capovilla <fcapovilla>
Component:	Circulation	Assignee:	Frédérick Capovilla <fcapovilla>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	normal
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, gmcharlt, paul.poulain
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Adds a hidden input to keep the op value in overdue.pl F. Capolival patch ported to TT Signed-off patch Bug 6817 Downloading the overdues as a file ignores the filters if the page isn't in english

Description Frédérick Capovilla 2011-08-30 14:46:57 UTC Comment hidden (obsolete)

Created attachment 5220 [details] [review]
Adds a hidden input to keep the op value in overdue.pl

When the intranet is translated in another language than english, the filters are ignored when downloading the overdues as a file in overdue.pl

To reproduce :
* Set Koha to a language other than english
* Go in circ/overdues.pl
* Select some filters that affect the number of overdues that will be shown on the page.
* Click the link to download the overdues file.
* Not that the number of overdues in the file isn't the same as the number of overdues on the page. The file always contains all overdues, so filters are ignored.

Cause : The "value" of the button is used by overdue.pl to know if a filter is used, but this value is changed when the page is translated.

Fix : A hidden input was added next to the button so the value of "op" doesn't get translated.

Comment 1 Frédéric Demians 2011-09-05 07:15:32 UTC Comment hidden (obsolete)

Created attachment 5309 [details] [review]
F. Capolival patch ported to TT

I confirm the bug and the solution. I ported it to Template Toolkit. Plesae sign-off.

Comment 2 Owen Leonard 2011-10-06 19:41:41 UTC Comment hidden (obsolete)

Created attachment 5750 [details] [review]
Signed-off patch

Comment 3 Paul Poulain 2011-10-07 16:07:55 UTC

Created attachment 5780 [details] [review]
Bug 6817 Downloading the overdues as a file ignores the filters if the page isn't in english

F. Capovila patch ported to TT.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Comment 4 Paul Poulain 2011-10-07 16:10:24 UTC

QA comment
  * small patch
  * fixes nicely a very annoying problem for non-english users
  * good test plan

passed QA !

Comment 5 Chris Cormack 2011-10-09 06:44:12 UTC

Pushed, please test

Comment 6 Jared Camins-Esakov 2012-12-31 00:20:50 UTC

There have been no further reports of problems so I am marking this bug resolved.