Summary: | Show a warning if placing a reserve will incur a cost | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | OPAC | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, koha.sekjal, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 6857: display a charge warning alert for reserves
[SIGNED-OFF] Bug 6857: display a charge warning alert for reserves Follow up to Bug 6857: Change language from 'reserve' to 'hold' Follow up to Bug 6857: Change language from 'reserve' to 'hold' |
Description
Robin Sheat
2011-09-08 06:33:08 UTC
Created attachment 5352 [details] [review] Bug 6857: display a charge warning alert for reserves If a user is placing a reserve on the OPAC, this'll let them know that it's going to cost them. Author: Chris Cormack <chrisc@catalyst.net.nz> How do I test this? I have an item type with a rental charge and I placed a hold on that item type and no warning appeared telling me that I was going to be charged the rental fee. So I'm wondering what cost we're talking about. Nicole Oh, I forgot to squash two patches. The former being the syspref that turns this on. Let me try that again... Oh, I was wrong about the syspref thing, was looking at the wrong branch. The issue is that it applies to reserves, not rental charges. What reserve has a fee associated with it? Where do I set a fee associated with a hold? The only fee I know of is if the item is overdue or if the item has a rental charge. Hi Nicole, hold fees can be set for borrower category types. Something else that would be nice to have in circ matrix :) a sign that i'm just way way way too braindead! Off to retest. Created attachment 5390 [details] [review] [SIGNED-OFF] Bug 6857: display a charge warning alert for reserves If a user is placing a reserve on the OPAC, this'll let them know that it's going to cost them. Author: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Created attachment 5391 [details] [review] Follow up to Bug 6857: Change language from 'reserve' to 'hold' Reserves are called holds all throughout the OPAC so this follow up updates the language in this patch to match the standard. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Original patch signed off, follow up needs a sign off though. Sorry to be a pain, but the <div> in the template for this message needs to have an ID so that it's content can be altered easily with JQuery (for any libraries who may not want this exact message to be displayed). Marking as Failed QA until 'id=reserve_fee' is added. i'll add that to my follow up. Created attachment 5392 [details] [review] Follow up to Bug 6857: Change language from 'reserve' to 'hold' Reserves are called holds all throughout the OPAC so this follow up updates the language in this patch to match the standard. Also adds an id tag to the message for altering with JQuery. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> follow up includes the ID tag, so first patch is still signed off and follow up needs sign off. Thank you, Nicole. Signing off on your followup, and marking both patches as Passed QA. Pushed, please test |