Summary: | Can't set default SMS messaging options when defining a patron category | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, f.demians, gmcharlt, nengard |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed fix
[SIGNED-OFF] Fix for Bug 6872 - Can't set default SMS messaging options for patron category |
Description
Owen Leonard
2011-09-15 13:38:16 UTC
Created attachment 5437 [details] [review] Proposed fix I don't understand and can't see what it adds. Is there something missing? Perl script is modified but not the related template. Here are the conditions for observing the bug: 1. Turn on EnhancedMessagingPreferences 2. Fill the SMSSendDriver preference with any value to enable it 3. Edit a patron category In the table of options labeled "Default messaging preferences for this patron category" you will see a column for Email but not for SMS. When the SMSSendDriver preference is populated there should also be a column for SMS. The template checks for the SMSSendDriver preference, but the script didn't pass the variable to the template. This patch corrects it to do so. Created attachment 5594 [details] [review] [SIGNED-OFF] Fix for Bug 6872 - Can't set default SMS messaging options for patron category Passing SMS driver preference value to the template so that SMS options can be displayed when appropriate. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Simple fix, pushed, please test |