Summary: | Add integration for EBSCO's Novelist Select service | ||
---|---|---|---|
Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
Component: | OPAC | Assignee: | Ian Walls <koha.sekjal> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 11606 | ||
Attachments: |
Proposed Patch (functionality)
Proposed patch (DB changes) Signed-off patch Signed-off patch |
Description
Ian Walls
2011-09-21 19:13:45 UTC
Created attachment 5547 [details] [review] Proposed Patch (functionality) Adds Novelist Select functionality to OPAC. Created attachment 5548 [details] [review] Proposed patch (DB changes) Adds necessary sysprefs to sysprefs.sql and updatedatabase.pl Created attachment 5776 [details] [review] Signed-off patch Created attachment 5777 [details] [review] Signed-off patch These patches tested fine for me. The changes to the code are minimal, since the Novelist data, like LibraryThing data, is pulled in via JavaScript. A couple of comments, neither of which would prevent this from going forward: The option to put the content in the right-hand sidebar doesn't really work well because of the quantity of content. It's too squeezed. Since the position of the content is controlled by a system preference, this is easily avoided. A good follow-up might be to add <noscript> text following the model of the LibraryThing content. Otherwise users with JS disabled will see the Novelist heading but no content and no explanation. Chris, as this patch introduces new strings, I'd like to mark Passed QA now. This is purely self-interest, however, and I would prefer another set of eyes on it. It's largely a template-only change, and turning off the feature leave the OPAC exactly as it is now, but I just feel shady about pushing this through when I'm the author. Have tested this, it introduces no regressions and is a nice feature, pushing As far as I can tell, this is working properly. Closing. |