Summary: | SYStem preference XISBNDailyLimit preference text error | ||
---|---|---|---|
Product: | Koha | Reporter: | cmeech |
Component: | System Administration | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, nengard |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 6935: Correct XISBNDailyLimit for new installations
Bug 6935: Correct XISBNDailyLimit for new installations |
Description
cmeech
2011-09-28 22:13:43 UTC
The limit was changed to 999 a while ago: http://koha-community.org/oclc-raises-daily-noncommercial-usage-limits-for-xisbn-and-xissn/ But it seems 499 is correct? http://www.worldcat.org/affiliate/webservices/xisbn/app.jsp 'The xISBN Web service is free for non-commercial use when usage does not exceed 500 requests per day. Free usage is governed by the WorldCat Affiliate Terms and Conditions. See the xISBN API for instructions.' *** Bug 5774 has been marked as a duplicate of this bug. *** I can make a patch to correct it, but which value do we want? 999 (because the max is 1000) I have checked the pref file, the text there is correct: OCLC: - - pref: XISBN choices: yes: Use no: "Don't use" - the OCLC xISBN service to show other editions of a title (when either FRBRizeEditions or OPACFRBRizeEditions is on). - - Use the <a href="http://www.worldcat.org/affiliate/webservices/xisbn/app.jsp">OCLC affiliate ID</a> - pref: OCLCAffiliateID - to access the xISBN service. Note that unless you have signed up for an ID, you are limited to 1000 requests per day. - - Only use the xISBN service - pref: XISBNDailyLimit class: integer - times a day. Unless you are paying for the xISBN service, you should leave this at the default of 999 (as detailed above). Perhaps this is a problem in the po files of the installed language? In my newly created database the value is set to 499 instead of 999 - investigating. Created attachment 6464 [details] [review] Bug 6935: Correct XISBNDailyLimit for new installations This corrects the value of XISBNDailyLimit in the system preferences installation file to 999 instead of 499. The file was missed in an earlier update, so new installations have different values than older installations that were updated. Another patch with a database update is needed. Sending this patch first, until it's clear how database updates will work for 3.8. To test: 1) Recreate your database from scratch 2) Check your system preference XISBNDailyLimit shows 999 instead of 499, matching the description of the system preference. Created attachment 6736 [details] [review] Bug 6935: Correct XISBNDailyLimit for new installations This corrects the value of XISBNDailyLimit in the system preferences installation file to 999 instead of 499. The file was missed in an earlier update, so new installations have different values than older installations that were updated. Another patch with a database update is needed. Sending this patch first, until it's clear how database updates will work for 3.8. To test: 1) Recreate your database from scratch 2) Check your system preference XISBNDailyLimit shows 999 instead of 499, matching the description of the system preference. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA comment: trivial patch, passed QA patch pushed, please test This was included in the 3.6 branch prior to 3.6.4. |