Summary: | Toolbar on reading history broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | koha.sekjal, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/members/readingrec.pl?borrowernumber=20 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
screenshot
Proposed fix [SIGNED-OFF] Fix for Bug 6955, Toolbar on reading history broken Fix for Bug 6955, Toolbar on reading history broken |
Created attachment 5676 [details] [review] Proposed fix Table sorter script causes error if there is no <tbody> to sort. JS errors cause the YUI toolbar js to abort, causing the problem observed. When there are no results the whole table should be omitted and a message displayed in its place. Created attachment 5757 [details] [review] [SIGNED-OFF] Fix for Bug 6955, Toolbar on reading history broken Table sorter script causes error if there is no <tbody> to sort. JS errors cause the YUI toolbar js to abort, causing the problem observed. When there are no results the whole table should be omitted and a message displayed in its place. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: - check toolbar on top of patron reading history with no entries - check toolbar on top of patron reading history after a few checkouts Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 5849 [details] [review] Fix for Bug 6955, Toolbar on reading history broken Table sorter script causes error if there is no <tbody> to sort. JS errors cause the YUI toolbar js to abort, causing the problem observed. When there are no results the whole table should be omitted and a message displayed in its place. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: - check toolbar on top of patron reading history with no entries - check toolbar on top of patron reading history after a few checkouts Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA comment * Minor problem, not major * works as expected, good description, small patch passed QA Note for 3.6 RM : this patch adds a string. We've string freezed, it's up to you to decide wether to apply the patch or not : the problem is minor, but it's a bug, definetly Template only change, wrapping a conditional around dependent code. Introduces new strings, so it may need to wait until 3.6.1, but as for now, it's Passed QA. patch pushed, please test (made a small mistake when pushing : don't search for a new/bug_6955 branch, it was one of my 1st push) There have been no further reports of problems so I am marking this bug resolved. |
Created attachment 5673 [details] screenshot The toolbar on the reading history page in patron account is broken.