Summary: | Missing spaces in translated templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Frédéric Demians <f.demians> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 6958 : Fix for leading spaces being stripped on translation
[SIGNED-OFF] Bug 6958 : Fix for leading spaces being stripped on translation |
Description
Katrin Fischer
2011-10-02 21:14:24 UTC
Hmm it looks like its the replacement when putting the .po file back into the templates that is the problem. Investigating more Right here the problem </a> › Error 405</div> Becomes </a>› Fehler 405</div> Tracking down why now > Tracking down why now
I've tried without success. It seems that stings containing › are parsed as a TEXT_PARAMATRIZED tokens, which is false.
I have a patch which adds the space back in. Katrin is testing it more, to make sure it has no unintended side effects. Its not a very elegant solution but seems to work. Ill attach it to the bug once Katrin has a little more time to test Created attachment 5707 [details] [review] Bug 6958 : Fix for leading spaces being stripped on translation This will re-add any leading spaces, so formatting is not messed Please test a lot, it is pretty harmless only adds whitespace if needed. Created attachment 5712 [details] [review] [SIGNED-OFF] Bug 6958 : Fix for leading spaces being stripped on translation Tested on 5.4.x with complete German po files. The logic in this patch looks sound; the same basic functionality is preserved, with an expansion in the event that the string starts with leading spaces, which are now preserved. Logic is actually now much more readable, so improvement there. Marking as Passed QA. Pushed, please test |