I noticed that especially in breadcrubs and texts that contains links and normal text spaces are missing from the po file and so from the translated templates.
1) Breadcrumbs on patron module start page:
English: Start > Patrons
German: Start> Benutzer
The po file for the first part of the breadcrumbs looks like this:
When changing "Start" to "Start " the templates look correct.
This is only an example, the spaces before the > are missing in general on all breadcrumbs.
2) Fines on patron account (check out tab)
English: Fines: Patron has Outstanding fines of 1.00. Make Payment
German: Gebühren:Benutzer hat offene Gebühren in Höhe von 1.00. Zahlung
The space after Fines: is missing.
The po fiole looks like this:
msgid "Patron has "
msgstr "Benutzer hat "
There are lot of other examples.
Hmm it looks like its the replacement when putting the .po file back into the templates that is the problem.
Right here the problem
</a> › Error 405</div>
</a>› Fehler 405</div>
Tracking down why now
> Tracking down why now
I've tried without success. It seems that stings containing › are parsed as a TEXT_PARAMATRIZED tokens, which is false.
I have a patch which adds the space back in. Katrin is testing it more, to make sure it has no unintended side effects. Its not a very elegant solution but seems to work.
Ill attach it to the bug once Katrin has a little more time to test
Created attachment 5707 [details] [review]
Bug 6958 : Fix for leading spaces being stripped on translation
This will re-add any leading spaces, so formatting is not messed
Please test a lot, it is pretty harmless only adds whitespace if needed.
Created attachment 5712 [details] [review]
[SIGNED-OFF] Bug 6958 : Fix for leading spaces being stripped on translation
Tested on 5.4.x with complete German po files.
The logic in this patch looks sound; the same basic functionality is preserved, with an expansion in the event that the string starts with leading spaces, which are now preserved. Logic is actually now much more readable, so improvement there. Marking as Passed QA.
Pushed, please test