Summary: | 'Add child' function should be dependant on system preference 'borrowerRelationship' | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Aleksa Vujicic <aleksa> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | m.de.rooy, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
The 'Add Child' button is not shown if 'borrowerRelationship' is empty. System preference description also changed.
[SIGNED-OFF] Bug 6964 - 'Add child' function should be dependant on system preference 'borrowerRelationship' Followup for typo on borrowernumber Follow-up fixing typo |
Description
Katrin Fischer
2011-10-04 13:11:00 UTC
Created attachment 7306 [details] [review] The 'Add Child' button is not shown if 'borrowerRelationship' is empty. System preference description also changed. Created attachment 7317 [details] [review] [SIGNED-OFF] Bug 6964 - 'Add child' function should be dependant on system preference 'borrowerRelationship' The 'Add Child' button is not shown if 'borrowerRelationship' is empty. System preference description changed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment: * tiny patch, nothing to say about the code, it's OK * I think it's an ENH, that could surprise some libraries. Changing the severity & version to have it for 3.8 Note that a follow-up fixed missing comma after total_due: diff --git a/members/paycollect.pl b/members/paycollect.pl index cbddc05..e05a5a6 100755 --- a/members/paycollect.pl +++ b/members/paycollect.pl @@ -138,6 +138,7 @@ $template->param( borrowenumber => $borrowernumber, # some templates require global borrower => $borrower, total => $total_due + activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''), ); As Paul noted in commit: Seems everybody forgot to test paycollect, as there was a syntax error! Created attachment 7430 [details] [review] Followup for typo on borrowernumber Fixing trivial typo, setting status to Passed QA again. Created attachment 7431 [details] [review] Follow-up fixing typo Second try to add attachment.. |