In academic libraries the features to 'Add childs' is not used and the button in patron account causes confusion.
I suggest to check if the system preference 'borrowerRelationship' is not empty to decide if the button is shown or not.
The description of the system preference could be amended to say 'Leave empty to deactivate'.
Created attachment 7306 [details] [review]
The 'Add Child' button is not shown if 'borrowerRelationship' is empty. System preference description also changed.
Created attachment 7317 [details] [review]
[SIGNED-OFF] Bug 6964 - 'Add child' function should be dependant on system preference 'borrowerRelationship'
The 'Add Child' button is not shown if 'borrowerRelationship' is empty.
System preference description changed.
Signed-off-by: Owen Leonard <email@example.com>
* tiny patch, nothing to say about the code, it's OK
* I think it's an ENH, that could surprise some libraries. Changing the severity & version to have it for 3.8
Note that a follow-up fixed missing comma after total_due:
diff --git a/members/paycollect.pl b/members/paycollect.pl
index cbddc05..e05a5a6 100755
@@ -138,6 +138,7 @@ $template->param(
borrowenumber => $borrowernumber, # some templates require global
borrower => $borrower,
total => $total_due
+ activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''),
As Paul noted in commit: Seems everybody forgot to test paycollect, as there was a syntax error!
Created attachment 7430 [details] [review]
Followup for typo on borrowernumber
Fixing trivial typo, setting status to Passed QA again.
Created attachment 7431 [details] [review]
Follow-up fixing typo
Second try to add attachment..