Summary: | Web installer does not switch language | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Henri-Damien LAURENT <henridamien> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, f.demians, gmcharlt, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 5660 | ||
Bug Blocks: | |||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 7026 Web installer does not switch language Bug 7026 Web installer does not switch language |
I confirm the bug. It has been introduced by patch for bug 5660. A test is done on a system preference to avoid bug 5660. It works for update but it can't work for a fresh install which hasn't a populated DB at first. I will propose a patch. But someone should check it doesn't introduce back bug 5660. Created attachment 5917 [details] [review] Proposed patch Created attachment 5950 [details] [review] [SIGNED-OFF] Bug 7026 Web installer does not switch language Language installer should switch to template files of language selected in first step. It used to do that, but the feature seems to be broken now. Web installer remains English after selecting a different language. To reproduce: - make sure your database is empty - run 'perl translate install <some language> - access web installer - select language other then en on the first page => templates should change to translated templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan provided works, correct language and sample files are selected. In a second test I deleted the staff templates for de-DE and repeated the steps. de-DE is not offered in the language selection of the web installer now, but does appear in the opaclanguages list after running the web installer. (Bug 5660) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 5957 [details] [review] Bug 7026 Web installer does not switch language Language installer should switch to template files of language selected in first step. It used to do that, but the feature seems to be broken now. Web installer remains English after selecting a different language. To reproduce: - make sure your database is empty - run 'perl translate install <some language> - access web installer - select language other then en on the first page => templates should change to translated templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan provided works, correct language and sample files are selected. In a second test I deleted the staff templates for de-DE and repeated the steps. de-DE is not offered in the language selection of the web installer now, but does appear in the opaclanguages list after running the web installer. (Bug 5660) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA comment : * good description & test plan * nasty bug for non english setups, solved by this patch * clean code passed QA (upgrading severity to CRI) Pushed, please test |
Language installer should switch to template files of language selected in first step. It used to do that, but the feature seems to be broken now. Web installer remains English after selecting a different language. To reproduce: - make sure your database is empty - run 'perl translate install <some language> - access web installer - select language other then en on the first page > templates should change to translated templates