Summary: | HidePatronName not hiding in all places | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Circulation | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P3 | CC: | gmcharlt, katrin.fischer, koha.sekjal, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed Patch
[SIGNED-OFF] Bug 7097: HidePatronName not hiding on issue history |
Description
Nicole C. Engard
2011-10-26 17:20:31 UTC
No name information in circ/bookcount.tt, so it looks like just catalogue/issuehistory.tt (for now). Created attachment 7054 [details] [review] Proposed Patch Adds HidePatronName support to Issue History tab Created attachment 7055 [details] [review] [SIGNED-OFF] Bug 7097: HidePatronName not hiding on issue history HidePatronName wasn't being respected on a titles Checkout History tab. This patch exports the preference to the template (if set), and then toggles the display between patron cardnumber (if 'on') or the name (if 'off') To test: Enable HidePatronName Go to the Checkout History tab of an item that has been checked out before You should see the patron's cardnumber instead of their surname, firstname Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> QA comment: tiny patch, no specific comment side comment: I feel HidePatronName is wrongly named. I'm also wondering if it's really a needed syspref ? (what could be the use case ?) All of this could be solved if we had presentation object to let the library define what appears when we need a "short patron informations"... but that's another story, no doubt ;-) This preference is necessary for libraries that want to hide patron names from the screen. It's a privacy issue for libraries where the staff machine screens a visible to the public and in libraries where they have volunteers who they don't want the names to show to. Nicole |