Bug 7097 - HidePatronName not hiding in all places
Summary: HidePatronName not hiding in all places
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.6
Hardware: All All
: P3 normal (vote)
Assignee: Kyle M Hall
QA Contact: Bugs List
Depends on:
Reported: 2011-10-26 17:20 UTC by Nicole C. Engard
Modified: 2013-12-05 19:57 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Proposed Patch (2.45 KB, patch)
2012-01-05 18:29 UTC, Ian Walls
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7097: HidePatronName not hiding on issue history (2.52 KB, patch)
2012-01-05 18:43 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-10-26 17:20:31 UTC
if you go to the item's circ history you can see the names - it does hide from the currently checked out summary, but not the past checkouts.


and possibly (I don't have one with a name showing ... so I can't test).

Comment 1 Ian Walls 2011-11-01 05:02:10 UTC
No name information in circ/bookcount.tt, so it looks like just catalogue/issuehistory.tt (for now).
Comment 2 Ian Walls 2012-01-05 18:29:37 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2012-01-05 18:43:01 UTC
Created attachment 7055 [details] [review]
[SIGNED-OFF] Bug 7097: HidePatronName not hiding on issue history

HidePatronName wasn't being respected on a titles Checkout History tab.  This patch
exports the preference to the template (if set), and then toggles the display between
patron cardnumber (if 'on') or the name (if 'off')

To test:

Enable HidePatronName
Go to the Checkout History tab of an item that has been checked out before
You should see the patron's cardnumber instead of their surname, firstname

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 4 Paul Poulain 2012-01-17 17:01:47 UTC
QA comment: tiny patch, no specific comment

side comment: I feel HidePatronName is wrongly named. I'm also wondering if it's really a needed syspref ? (what could be the use case ?) All of this could be solved if we had presentation object to let the library define what appears when we need a "short patron informations"... but that's another story, no doubt ;-)
Comment 5 Nicole C. Engard 2012-01-17 18:13:25 UTC
This preference is necessary for libraries that want to hide patron names from the screen.  It's a privacy issue for libraries where the staff machine screens a visible to the public and in libraries where they have volunteers who they don't want the names to show to.