| Summary: | After deleting order from order receive page redirect fails | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | julian.maurice, koha.sekjal, paul.poulain |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed fix
Signed off patch (Proposed fix) |
||
|
Description
Owen Leonard
2011-10-31 14:40:18 UTC
Created attachment 6125 [details] [review] Proposed fix The order modification script doesn't retrieve an order's basket when doing a delete, so the template must explicitly pass the basket number if we want the redirect to work. Created attachment 6187 [details] [review] Signed off patch (Proposed fix) The patch fix the problem, so I signed it. But I wonder if this is the right way to fix the problem. Why do we have to pass ordernumber, basketno and biblionumber for cancelling an order? I think the ordernumber is sufficient (it has to be sufficient). (In reply to comment #2) > Why do we have to > pass ordernumber, basketno and biblionumber for cancelling an order? See addorder.pl. DelOrder() requires biblionumber and ordernumber. basketno is required if you want to correctly redirect the user back to the right place. Template only change, passes variable explicitly as necessary to get the redirect working. Marking passed QA patch pushed, please test The links are redirecting to the right basket page now, but I think it would be better if they redirected back to the order receive page? Included in 3.6 prior to 3.6.5. |