Bug 7120 - After deleting order from order receive page redirect fails
Summary: After deleting order from order receive page redirect fails
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 14:40 UTC by Owen Leonard
Modified: 2013-12-05 19:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (3.40 KB, patch)
2011-10-31 15:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Signed off patch (Proposed fix) (3.42 KB, patch)
2011-11-04 09:13 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2011-10-31 14:40:18 UTC
After one deletes an order from the order receive page the script tries to redirect you to basket.pl. However, the basketno parameter is empty.
Comment 1 Owen Leonard 2011-10-31 15:04:59 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2011-11-04 09:13:48 UTC
Created attachment 6187 [details] [review]
Signed off patch (Proposed fix)

The patch fix the problem, so I signed it.
But I wonder if this is the right way to fix the problem. Why do we have to pass ordernumber, basketno and biblionumber for cancelling an order? I think the ordernumber is sufficient (it has to be sufficient).
Comment 3 Owen Leonard 2011-11-04 12:55:22 UTC
(In reply to comment #2)
> Why do we have to
> pass ordernumber, basketno and biblionumber for cancelling an order?

See addorder.pl. DelOrder() requires biblionumber and ordernumber. basketno is required if you want to correctly redirect the user back to the right place.
Comment 4 Ian Walls 2011-12-02 21:01:20 UTC
Template only change, passes variable explicitly as necessary to get the redirect working.  Marking passed QA
Comment 5 Paul Poulain 2011-12-06 11:09:36 UTC
patch pushed, please test
Comment 6 Katrin Fischer 2011-12-28 02:00:46 UTC
The links are redirecting to the right basket page now, but I think it would be better if they redirected back to the order receive page?
Comment 7 Jared Camins-Esakov 2012-05-23 12:12:42 UTC
Included in 3.6 prior to 3.6.5.