Summary: | Can't add tags on list | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Lists | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed fix
[SIGNED-OFF] Bug 7226 - can't add tags on list [SIGNED-OFF] Bug 7280 - can't place hold without selecting on list |
Description
Nicole C. Engard
2011-11-15 15:47:55 UTC
Created attachment 6600 [details] [review] Proposed fix Incorrect check for TagsInputOnList was preventing the right JavaScript from being triggered, and markup was nested inside the wrong logic for the confirmation message to be displayed consistently. Created attachment 6602 [details] [review] [SIGNED-OFF] Bug 7226 - can't add tags on list Incorrect check for TagsInputOnList was preventing the right JavaScript from being triggered, and markup was nested inside the wrong logic for the confirmation message to be displayed consistently. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Created attachment 6603 [details] [review] [SIGNED-OFF] Bug 7280 - can't place hold without selecting on list JavaScript was looking for clicks on links with class "hold," and incorrectly triggering the check for checked checkboxes. Making the selection stricter lets the JS function as it should while allowing people to place individual holds directly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Comment on attachment 6603 [details] [review] [SIGNED-OFF] Bug 7280 - can't place hold without selecting on list Attached wrong. QA comment: small patch, template change only prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok passed QA Patch pushed, please test |