Summary: | System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet) | ||
---|---|---|---|
Product: | Koha | Reporter: | Juan Romay Sieira <juan.sieira> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P4 | CC: | chris, gmcharlt, m.de.rooy, nengard, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 9166 | ||
Bug Blocks: | |||
Attachments: |
Patch
Signed-off patch Patch to apply in current master Bug 7261 System Preference to select the first day of week Followup to make tests consistent |
Description
Juan Romay Sieira
2011-11-24 16:50:06 UTC
Comment hidden (obsolete)
Created attachment 6601 [details] [review] Signed-off patch Works as advertised. Nice internationalization enhancement. Just a few questions/remarks before finishing QA: 1 Would it not be better to move this pref to Internationalization tab instead of Administration? 2 I would recommend to make the two tests on the preference in Auth.pm identical. Currently, it works, but things can change. 3 Is opac-reserve template the only one needing the firstDay parameter on the opac side? I notice that at the staff side the same change is in a common calendar-setup file. For the rest, things look very good to me. Could you clarify or send a follow up for the points above? Thanks. > 3 Is opac-reserve template the only one needing the firstDay parameter on the > opac side? I notice that at the staff side the same change is in a common > calendar-setup file. I noticed the same thing, and submitted a follow-up to Bug 2307. Changing status to reflect pending state. See comment 2. Created attachment 7538 [details] [review] Patch to apply in current master This patch applies to current master. The syspref was moved from Administration to Internationalization tab. (In reply to comment #2) > Just a few questions/remarks before finishing QA: > > 1 Would it not be better to move this pref to Internationalization tab instead > of Administration? I changed it to the tab you mentioned above. > 2 I would recommend to make the two tests on the preference in Auth.pm > identical. Currently, it works, but things can change. > 3 Is opac-reserve template the only one needing the firstDay parameter on the > opac side? I notice that at the staff side the same change is in a common > calendar-setup file. I did a search over the opac templates and I only found it in opac-reserve.tt > > For the rest, things look very good to me. > Could you clarify or send a follow up for the points above? Thanks. Created attachment 7999 [details] [review] Bug 7261 System Preference to select the first day of week Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 8183 [details] [review] Followup to make tests consistent Marking it as Passed QA, while adding a followup to make the two tests in Auth.pm the same. Trivial merge conflict in sysprefs.sql I'm not sure this syspref won't be deprecated by the datepicker change to switch to a jquery datepicker, but until then... patch pushed ! In fact we may be able to tie the configuration of the datepicker to the current localization settings. There are a lot of options built in: http://jqueryui.com/demos/datepicker/#localization This says it was pushed to master, but changing this preference's value in master doesn't seem to do anything for me .... Nicole, try clearing your browser cache. The patch includes changes to js files which might need to be refreshed. Bingo! and good tip to include in the manual. Nicole Working in the staff client, not on opac-reserve.pl. Looks like this is working in master. |