Bug 2307 - Calendar widget cannot be translated
Summary: Calendar widget cannot be translated
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
Depends on:
Reported: 2008-07-04 02:15 UTC by Chris Cormack
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Proposed fix (4.07 KB, patch)
2010-07-13 14:00 UTC, Owen Leonard
Details | Diff | Splinter Review
screenshot of translated calendar (22.96 KB, image/png)
2010-07-13 20:26 UTC, Katrin Fischer
Follow-up fix (3.92 KB, patch)
2011-12-06 16:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 2307 - Calendar widget cannot be translated (3.93 KB, patch)
2011-12-06 21:43 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:49:11 UTC

---- Reported by serhijdubyk@gmail.com 2008-07-04 02:15:06 ----

Way to translate calendar interface in other languages:
1) In files:
make next changes
2) replace string

<script type="text/javascript" src="<!-- TMPL_VAR name="themelang" -->/lib/calendar/calendar-en.js"></script>

with next

<!-- TMPL_VAR ESCAPE=JS EXPR="'<script type='" -->"<!-- TMPL_VAR ESCAPE=JS EXPR="'text/javascript'" -->"<!-- TMPL_VAR ESCAPE=JS EXPR="' src='" -->"<!-- TMPL_VAR name="themelang" -->/lib/calendar/calendar-en.js"<!-- TMPL_VAR ESCAPE=JS EXPR="'>'" --></script>

3) In result in po-files we found string-term


that can be translated, i.e., as next


4) Language pack can be found here:
(extract lang from jscalendar 1.0, languages work good in calendar.js version in Koha, I tested uk & ru)

also some new and updated languages present here:
(I can help with extracting all languages from here and make lang-pack for Koha, contact me - serhijdubyk(fine_symbol)gmail.com)

... I tested such sheme for Koha RC1 - all good

---- Additional Comments From jmf@liblime.com 2008-07-08 17:08:12 ----

This is a good idea, and I'd like to suggest we implement it for rel_3_2, as I think we'd need to do a bit more testing and documenting for translations to get it into 3.0. Thanks!

---- Additional Comments From oleonard@myacpl.org 2008-09-17 08:28:13 ----

The template can be aware of the current language, so why not just do:

<script type="text/javascript" src="<!-- TMPL_VAR name="themelang"
-->/lib/calendar/calendar-<!-- TMPL_VAR NAME="language" -->.js"></script>

---- Additional Comments From kyle.m.hall@gmail.com 2008-12-05 09:35:43 ----

I've submitted a patch that ports my dev_week reserves enhancements to Koha 3.

---- Additional Comments From nengard@gmail.com 2009-12-23 17:59:14 ----

This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate.

--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:49 UTC  ---

This bug was previously known as _bug_ 2307 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2307

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was serhijdubyk@gmail.com.

Comment 1 Owen Leonard 2010-07-13 14:00:09 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2010-07-13 20:26:05 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2010-12-14 06:41:18 UTC
Patch pushed, please test
Comment 4 MJ Ray (software.coop) 2011-01-08 11:13:36 UTC
This bug is mentioned in:
Possible fix for Bug 2307,	Calendar widget cannot be translated http://lists.koha-community.org/pipermail/koha-patches/2010-December/013260.html
Comment 5 Owen Leonard 2011-12-06 16:01:12 UTC
A follow-up is needed for the OPAC.
Comment 6 Owen Leonard 2011-12-06 16:11:42 UTC Comment hidden (obsolete)
Comment 7 Chris Cormack 2011-12-06 21:43:48 UTC
Created attachment 6619 [details] [review]
Bug 2307 - Calendar widget cannot be translated

Implementing the same fix in the OPAC which we now
use in the staff client.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 8 Paul Poulain 2011-12-16 17:27:33 UTC
QA comment: templates change only

i've tested that calendar still works after applying the patch. The rest will appear when translations will be updated !

passed QA

patch pushed, please test