| Summary: | Can't place hold without selecting on list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, paul.poulain |
| Version: | 3.4 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/opac-shelves.pl?viewshelf=3&sortfield= | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed fix
Bug 7280 - can't place hold without selecting on list [SIGNED-OFF] Bug 7289: Adds editionstatement field in neworderempty Bug 7289: Add biblioitems.editionstatement to missing sql files [SIGNED-OFF] Bug 7289: Adds editionstatement field in neworderempty |
||
|
Description
Nicole C. Engard
2011-11-30 17:37:32 UTC
Created attachment 6475 [details] [review] Proposed fix JavaScript was looking for clicks on links with class "hold," and incorrectly triggering the check for checked checkboxes. Making the selection stricter lets the JS function as it should while allowing people to place individual holds directly. Created attachment 6484 [details] [review] Bug 7280 - can't place hold without selecting on list JavaScript was looking for clicks on links with class "hold," and incorrectly triggering the check for checked checkboxes. Making the selection stricter lets the JS function as it should while allowing people to place individual holds directly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Template only change, easy to read, marking as Passed QA patch pushed, please test I had some trouble reproducing the error: it was because I tried to click on the "hold" button below the title when at least one checkbox was checked. In this case, the message was not appearing ! (severity lowered to "normal", it was easy to place a hold even with this bug) Created attachment 7579 [details] [review] [SIGNED-OFF] Bug 7289: Adds editionstatement field in neworderempty Tested: Database update - existing mapping - no pre existing mapping Frameworks PROBLEM: some languages are still missing, I think only untranslated frameworks are included in this patch. Acquisition - created a new order with edition filled out - checked edition was saved to the correct field in cataloguing - modified edition and checked display in acquisition - edition also displays on basket summary page Created attachment 7580 [details] [review] Bug 7289: Add biblioitems.editionstatement to missing sql files Follow-up for 7289 adding the new mapping to translated frameworks. Created attachment 7581 [details] [review] [SIGNED-OFF] Bug 7289: Adds editionstatement field in neworderempty Tested: Database update - existing mapping - no pre existing mapping Frameworks PROBLEM: some languages are still missing, I think only untranslated frameworks are included in this patch. Acquisition - created a new order with edition filled out - checked edition was saved to the correct field in cataloguing - modified edition and checked display in acquisition - edition also displays on basket summary page There have been no further reports of problems so I am marking this bug resolved. |