Summary: | General OPAC typo omnibus | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | ago, chris, jonathan.druart, magnus, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Signed patch
[SIGNED-OFF] Bug 7367: Add space before display of languages. Patch Patch Make translation possible of Close this window Patch for opac-suggestions template Bug 7367 - One "the" too many |
Description
Marcel de Rooy
2011-12-19 12:27:09 UTC
Created attachment 6866 [details] [review] Signed patch Adding a space before list of languages in language bar. At the same time serving as an example of the above.. Created attachment 6871 [details] [review] [SIGNED-OFF] Bug 7367: Add space before display of languages. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I am a bit confused why it does not work without the but patch fixes the display problem. Bug 7366 notes additonal display problems with the language chooser. Latest patch just replaces ' ' with " ', which is trivial. Marking Passed QA patch pushed, please test Attachment 6871 [details] has been pushed to master and stable.
Obsoleting patch and resetting report status.
Created attachment 7292 [details] [review] Patch 7367: Removing reintroduced debugging statement from Auth.pm (Since it is in a module, it actually refers to OPAC and staff) Created attachment 7293 [details] [review] Patch Copy-and-paste problems.. Created attachment 7684 [details] [review] Make translation possible of Close this window Trivial change in two opac templates. Test: opac-downloadshelf and opac-sendshelfform. Latest patch is template only change for translation purposes. Marking as Passed QA. opac-suggestions.pl?op=add currently: Only the title is required, but the more information you enter the easier it will be for the librarians to find title you're requesting. should be: Only the title is required, but the more information you enter the easier it will be for the librarians to find the title you're requesting. missing "the" before "title you're requesting." Adding this as note, I haven't fixed it yet because I hosed my Koha, and need to rebuild. Created attachment 10268 [details] [review] Patch for opac-suggestions template Typo found by Albert Oller. Very trivial fix. Trivial patch. Marking as Passed QA. Comment on attachment 10268 [details] [review] Patch for opac-suggestions template patch pushed String changes, held for 3.8.3 Pushed to 3.8.x will be in 3.8.3 Created attachment 11076 [details] [review] Bug 7367 - One "the" too many On line 123 it says "of the the last". One "the" is probably enough. Trivial fix. Comment on attachment 11076 [details] [review] Bug 7367 - One "the" too many This patch has been pushed All the patches on this report have been pushed. (In reply to Owen Leonard from comment #20) > All the patches on this report have been pushed. No need to close this one? Has been reused numerous times.. The last patch on this bug was pushed two years ago, so I don't see a need for it to stay open. If new typos are found new bugs can be created. I think omnibus bugs are more important in situations when multiple separate bugs are required to fix a single larger issue. |