Corrects name of script; trivial fix, marking Passed QA

Patch pushed, please test

Attachment 6867 [details] has been pushed to master and stable.
Obsoleting the patch and resetting the status to NEW.

Corrects cut/paste error in usage.  Trivial change, clearly correct, passed QA.

Comment on attachment 8925 [details] [review]
[PATCH] 7368 Followup for indentation in VirtualShelves.pm

QA comment: this patch is indenting only, passed QA

Patch pushed in branch new/bug_7310 (and master, of course)

intranet-tmpl/prog/en/modules/help/tools/letter.tt:154

The transfer sliip is printed when you confirm a transfer from one branch to another in your system

(double ii in sliip)

Trivial string change for consistency.  Signing off and passing QA.

For an unknown reason, I get a nasty

fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 7368 typo: MARC -> Card
When you have resolved this problem run "git am --resolved".


Can you resubmit ?

trivial patch, pushed.

Typo fix but not involving translatable strings, will be in 3.8.1

*** Bug 8237 has been marked as a duplicate of this bug. ***

Passed QA

Comment on attachment 10191 [details] [review]
Patch for history.txt

this patch pushed

intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt:18
To edit the subfields, click 'Edit Subfields.'
->... Edit Subfields'.

intranet-tmpl/prog/en/modules/help/acqui/basketheader.tt:9
When finished, click 'Save.'
->...'Save'.

intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:26
li>Planning categories are used for statistical purposes. To learn more about planning categories, check out the Planning Category FAQ.
->Error with <li>?

(In reply to comment #21)
> intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt:18
> To edit the subfields, click 'Edit Subfields.'
> ->... Edit Subfields'.
> 
> intranet-tmpl/prog/en/modules/help/acqui/basketheader.tt:9
> When finished, click 'Save.'
> ->...'Save'.
> 
> intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:26
> li>Planning categories are used for statistical purposes. To learn more
> about planning categories, check out the Planning Category FAQ.
> ->Error with <li>?

Marc,
Please send a patch for comment9 and the above typos.
You can click take over on the assignee, if you do so.

Attachment 10458 [details]: Passed QA. Very trivial typo fix.
Marc: In this kind of case you could have attached your own sign-off. See comment1.

Comment on attachment 10458 [details] [review]
Bug 7368 - General staff client typo omnibus

This patch has been pushed

all patches pushed, back to assigned

Forget the latest patch please. I think we should remove this use statement after all; it seems not to be used anyhow..

(In reply to comment #30)
> Forget the latest patch please. I think we should remove this use statement
> after all; it seems not to be used anyhow..
Well, not that fast. We need it, but somewhere deeper. opac-sendbasket does not need to call [read: use] it. But via Template::Plugin::HtmlToText it is required via the template of sendbasket. So it should be there after all.

This patch displays a warning with the following command:
    perl koha_perl_deps.pl -i

koha_perl_deps.pl: Use of uninitialized value in formline at koha_perl_deps.pl line 65, <DATA> line 522.

I think it is caused by the missing 'min_ver' information.
However, I don't understand what is the value '2' for required. Can you shed some light on this please ?

(In reply to comment #33)
> This patch displays a warning with the following command:
>     perl koha_perl_deps.pl -i
> 
> koha_perl_deps.pl: Use of uninitialized value in formline at
> koha_perl_deps.pl line 65, <DATA> line 522.
> 
> I think it is caused by the missing 'min_ver' information.
> However, I don't understand what is the value '2' for required. Can you shed
> some light on this please ?

Good catch. I saw somewhere else that min_ver was not added too, will correct that now also. I tested about page, but should have run this script too. Thanks.

Still wondering about this error:
[Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value $version in numeric lt (<) at /usr/local/share/perl5/Modern/Perl.pm line 25.
[Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value $version in numeric lt (<) at /usr/local/share/perl5/Modern/Perl.pm line 25.

This is separate from the last patch and comes up in current master already.
Any idea?

(In reply to comment #35)
> Created attachment 11048 [details] [review]
> Adjusted patch for perl deps
> 
> Jonathan: Could you please add a signoff too?

Probably, usage=> Core could be amended to Unit tests..

*** Bug 8487 has been marked as a duplicate of this bug. ***

(In reply to comment #39)
> Created attachment 11069 [details] [review]
> [SIGNED-OFF] Adjusted patch for perl deps
> 
> hum... strange, I have no error on current master.
> 
> And your last patch fixes my previous problem :-)
> 
> Then I switch to signed-off

Thanks. What perl version are you using BTW ?

(In reply to comment #40)
> Thanks. What perl version are you using BTW ?
$ perl -v 
This is perl 5, version 14, subversion 2 (v5.14.2)

(In reply to comment #41)
> (In reply to comment #40)
> > Thanks. What perl version are you using BTW ?
> $ perl -v 
> This is perl 5, version 14, subversion 2 (v5.14.2)

Hmm. I have the same. If I run on master perl koha-perl-deps -a
I have the error referred above..
Looks like some module does not contain a version, but could not find it?

(In reply to comment #42)
> Hmm. I have the same. If I run on master perl koha-perl-deps -a
> I have the error referred above..
> Looks like some module does not contain a version, but could not find it?

Note that the error comes first, before the long listing of module names. You could easily miss it.

It seems it is caused by the version of Modern::Perl:

$pmvers Modern::Perl
1.03

My Modern/Perl.pm contains 
our $VERSION = '1.03';

Whereas a new version of this module contains:
Modern::Perl::VERSION {
    my ($self, $version) = @_;
    return $VERSION if $version < 2009;
    $wanted_date = $version if (caller(1))[3] =~ /::BEGIN/;
    return 2012;
}

Actually, I don't know how we can fix that.

(In reply to comment #44)
> It seems it is caused by the version of Modern::Perl:

Good, you found that. Interesting!
I have this version: $Modern::Perl::VERSION = '1.20120130' and the same routine.

But I still do not understand it completely. It seems like an error in Modern::Perl although its docs state that it is not necessary to pass a version or a year to Modern::Perl.
AFAIK we are not passing numbers to Modern::Perl in our Koha use statements. But when I test that in a simple script, I do not even raise this warning. What makes koha_perl_deps do raise that warning? 

Since this is not very important, I will copy the last comments on this error in a separate report. To be resolved one day :)

(In reply to comment #45)
> Since this is not very important, I will copy the last comments on this
> error in a separate report. To be resolved one day :)

See further bug 8491.

Comment on attachment 11069 [details] [review]
[SIGNED-OFF] Adjusted patch for perl deps

trivial patch, passed QA and pushed in one go

The latest patch doesn't apply on 3.8.x please resubmit if you think it should be there too.

Changed status to Pushed to master for inclusion of rebased 3.8.x patch.

Pushed to 3.8.x will be in 3.8.4

Thanks, Kathryn and Katrin!
Passed QA

Comment on attachment 11761 [details] [review]
[SIGNED-OFF] Bug 7368: fixed subsribe typo

This patch has been pushed

(In reply to comment #56)
> Note: ignored feature in most browsers! But dependant is ignored everywhere

Ignored by most browsers? Is it followed by *any* browsers? I suggest we remove rather than correct references to it.

(In reply to comment #57)
> Ignored by most browsers? Is it followed by *any* browsers? I suggest we
> remove rather than correct references to it.

Removing them in adjusted patch. Could you sign off? Thx.

QA comment:
 * small patch, cleaning code.
 * no change in strings
passed QA

This patch has been pushed to master.

Patch pushed to branch 3.10.x

Hey Marcel,

I think you have missed the word 'contain' somewhere here?
"The XML should only biblio information"

I am hesitating to bloat this with a followup, maybe you would like to just update your patch?

(In reply to comment #65)
> Hey Marcel,
> 
> I think you have missed the word 'contain' somewhere here?
> "The XML should only biblio information"
> 
> I am hesitating to bloat this with a followup, maybe you would like to just
> update your patch?

Hi Mirko,
If you signoff, I do not mind that you amend the commit for such things. Thx.

QA Comments:
Last patch changes some lines of documentation.
Marked as Passed QA.

Pushed to master and 3.10.x

QA comment for http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16095 : trivial patch, koha-qa OK, passed QA

This patch has been pushed to master.

This patch has been pushed to master and 3.12.x.

This patch has been pushed to master and 3.12.x.

Latest pushed to master.  Thanks, Connor!

Last patch has been pushed to 3.12.x, will be in 3.12.1.

Pushed to 3.10.x, will be in 3.10.7

Pushed to 3.8.x, will be in 3.8.14

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
Tested using second alternative

Just a note: if you update other lang files replacing INSERTs for UPDATEs
then you must install using EN and later apply lang files by hand.
If you do a translate first before webinstaller, and finish your install
in your lang, then that kind of file will fail.

Thanks, Bernardo.

> Just a note: if you update other lang files replacing INSERTs for UPDATEs
> then you must install using EN and later apply lang files by hand.
> If you do a translate first before webinstaller, and finish your install
> in your lang, then that kind of file will fail.

No, I am not suggesting a manual procedure. It will be done automatically in the web installer. Will open a new report for it soon.
(I started a discussion about this on dev list recently..)

Comment on attachment 19258 [details] [review]
Bug 7368: Followup for columns names in userflags.sql

Pushed latest to master.  Thanks, Marcel!