| Summary: | Create index for items.itemcallnumber | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Srdjan Jankovic <srdjan> |
| Component: | Cataloging | Assignee: | Srdjan Jankovic <srdjan> |
| Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jcamins, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
patch
bug_7509: Added index on items itemcallnumber bug_7509: Added index on items itemcallnumber Bug 7509: Added index on items itemcallnumber Bug 7509: Added index on items itemcallnumber |
||
|
Description
Srdjan Jankovic
2012-02-07 23:57:02 UTC
Created attachment 7498 [details] [review] patch Created attachment 7513 [details] [review] bug_7509: Added index on items itemcallnumber I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. I also added an atomicupdate to this patch (it was part of my testing, just thought I'd include it? Is there a preference?). Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. Created attachment 7516 [details] [review] bug_7509: Added index on items itemcallnumber I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. I also added an atomicupdate to this patch (it was part of my testing, just thought I'd include it? Is there a preference?). Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. I don't see any reason for using atomicupdate with something this simple. Created attachment 7603 [details] [review] Bug 7509: Added index on items itemcallnumber Comment from Liz: I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 7695 [details] [review] Bug 7509: Added index on items itemcallnumber Comment from Liz: I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. QA notes: rebased on latest master. Also added index name `itemcallnumber` to maintain consistency with all other indexes on items table. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Ian Walls <koha.sekjal@gmail.com> Simple change to add a new index. Rebased to latest master and modified some syntax to be consistent with other indexes on the same table. Marking as Passed QA. QA comment: the ` is a mysqlism, that is not needed. During Hackfest in Marseille, next month, we will get rid of it, so this patch would have been rejected in April. Accepted it as it's consistent with existing code, but i also had accepted the "no `" version. There have been no further reports of problems so I am marking this bug resolved. |