Bug 7509 - Create index for items.itemcallnumber
Summary: Create index for items.itemcallnumber
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Srdjan Jankovic
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 23:57 UTC by Srdjan Jankovic
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch (1.94 KB, patch)
2012-02-08 02:25 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
bug_7509: Added index on items itemcallnumber (3.04 KB, patch)
2012-02-08 17:39 UTC, Liz Rea
Details | Diff | Splinter Review
bug_7509: Added index on items itemcallnumber (3.04 KB, patch)
2012-02-08 17:48 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 7509: Added index on items itemcallnumber (2.19 KB, patch)
2012-02-13 01:52 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 7509: Added index on items itemcallnumber (2.36 KB, patch)
2012-02-16 16:33 UTC, Ian Walls
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Srdjan Jankovic 2012-02-07 23:57:02 UTC
Create index on items itemcallnumber. It will facilitate efficient search.
Comment 1 Srdjan Jankovic 2012-02-08 02:25:26 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2012-02-08 17:39:07 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2012-02-08 17:48:09 UTC Comment hidden (obsolete)
Comment 4 Jared Camins-Esakov 2012-02-13 01:46:16 UTC
I don't see any reason for using atomicupdate with something this simple.
Comment 5 Jared Camins-Esakov 2012-02-13 01:52:01 UTC Comment hidden (obsolete)
Comment 6 Ian Walls 2012-02-16 16:33:17 UTC
Created attachment 7695 [details] [review]
Bug 7509: Added index on items itemcallnumber

Comment from Liz:
I couldn't get this update to fire - I found a small syntax error in the
updatedatabase.pl for this, which I corrected with this patch.

Functionally, all of this works as tested (once the typos were fixed), but
this probably requires another sign-off.

QA notes: rebased on latest master.  Also added index name `itemcallnumber`
to maintain consistency with all other indexes on items table.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Comment 7 Ian Walls 2012-02-16 16:34:33 UTC
Simple change to add a new index.  Rebased to latest master and modified some syntax to be consistent with other indexes on the same table.  Marking as Passed QA.
Comment 8 Paul Poulain 2012-02-17 10:33:56 UTC
QA comment:
the ` is a mysqlism, that is not needed.
During Hackfest in Marseille, next month, we will get rid of it, so this patch would have been rejected in April.
Accepted it as it's consistent with existing code, but i also had accepted the "no `" version.
Comment 9 Jared Camins-Esakov 2012-12-31 00:38:24 UTC
There have been no further reports of problems so I am marking this bug resolved.