Summary: | opac-ics depends on Date::ICal which is largely unmaintained | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | OPAC | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jcamins, mjr, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 7532 - remove dependency on Date::ICal
Bug 7532 - remove dependency on Date::ICal |
Description
Robin Sheat
2012-02-12 02:12:16 UTC
Created attachment 7578 [details] [review] Bug 7532 - remove dependency on Date::ICal This removes the dependency on Date::ICal (which is largely unmaintained) and replaces it with DateTime::Format::ICal which can do the same job. It also updates all the docs and installation scripts to handle this change. Note that this causes a minor behaviour change: previously the generated times were converted to UTC, now they are left "floating" (that is, have no timezone attached) and so will appear as the local time when imported into a calendar. I don't anticipate this'll cause any issues however. To test: 1) As a user with some stuff issued, visit opac-ics.pl, save the calendar file. 2) Apply the patch 3) Do the same as 1) 4) Note that the files are substantively similar, accounting for the timezone difference noted in the commit message. Created attachment 7600 [details] [review] Bug 7532 - remove dependency on Date::ICal This removes the dependency on Date::ICal (which is largely unmaintained) and replaces it with DateTime::Format::ICal which can do the same job. It also updates all the docs and installation scripts to handle this change. Note that this causes a minor behaviour change: previously the generated times were converted to UTC, now they are left "floating" (that is, have no timezone attached) and so will appear as the local time when imported into a calendar. I don't anticipate this'll cause any issues however. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> *** Bug 7393 has been marked as a duplicate of this bug. *** Successfully replaces Date::ICal with DateTime::Format::ICal. Change in timezone is definitely worth noting, but shouldn't be a problem. Marking as Passed QA. Release Maintainer: does this change in opac-ics.pl functionality warrant holding off on backporting to 3.6.x and 3.4.x, or is the long-term maintainability of the dependency more important? If it affects your decision any, applying this patch is necessary for people who want to build custom packages and use a Debian testing environment, as Date::ICal is no longer there. Introduce a new dependancy, definetly something for 3.8 and not 3.6 There have been no further reports of problems so I am marking this bug resolved. |