Bug 7532 - opac-ics depends on Date::ICal which is largely unmaintained
Summary: opac-ics depends on Date::ICal which is largely unmaintained
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Robin Sheat
QA Contact: Ian Walls
URL:
Keywords:
: 7393 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-12 02:12 UTC by Robin Sheat
Modified: 2013-12-05 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7532 - remove dependency on Date::ICal (6.84 KB, patch)
2012-02-12 03:48 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 7532 - remove dependency on Date::ICal (6.94 KB, patch)
2012-02-13 00:59 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2012-02-12 02:12:16 UTC
Date::ICal is no longer really maintained, and is being dropped by
Debian at least:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653301

We should probably consider replacing it with DateTime::Format::ICal.

Date::ICal is only used in one place: opac/opac-ics.pl:

$ grep -ri 'Date::ical' *
C4/Installer/PerlDependencies.pm:    'Date::ICal' => {
INSTALL.fedora7:Date::ICal
opac/opac-ics.pl:use Date::ICal;
opac/opac-ics.pl:    my $datestart = Date::ICal->new( 
opac/opac-ics.pl:    my $dateend = Date::ICal->new( 

It's likely to make it hard to deploy the packages on a Debian testing system, and also upsets my build process which uses a testing chroot.
Comment 1 Robin Sheat 2012-02-12 03:48:21 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2012-02-12 03:52:27 UTC
To test:

1) As a user with some stuff issued, visit opac-ics.pl, save the calendar file.
2) Apply the patch
3) Do the same as 1)
4) Note that the files are substantively similar, accounting for the timezone difference noted in the commit message.
Comment 3 Jared Camins-Esakov 2012-02-13 00:59:52 UTC
Created attachment 7600 [details] [review]
Bug 7532 - remove dependency on Date::ICal

This removes the dependency on Date::ICal (which is largely
unmaintained) and replaces it with DateTime::Format::ICal which can do
the same job. It also updates all the docs and installation scripts to
handle this change.

Note that this causes a minor behaviour change: previously the generated
times were converted to UTC, now they are left "floating" (that is, have
no timezone attached) and so will appear as the local time when imported
into a calendar. I don't anticipate this'll cause any issues however.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 4 MJ Ray (software.coop) 2012-02-13 16:43:15 UTC
*** Bug 7393 has been marked as a duplicate of this bug. ***
Comment 5 Ian Walls 2012-02-16 21:49:27 UTC
Successfully replaces Date::ICal with DateTime::Format::ICal.  Change in timezone is definitely worth noting, but shouldn't be a problem.  Marking as Passed QA.

Release Maintainer:  does this change in opac-ics.pl functionality warrant holding off on backporting to 3.6.x and 3.4.x, or is the long-term maintainability of the dependency more important?
Comment 6 Robin Sheat 2012-02-16 22:19:09 UTC
If it affects your decision any, applying this patch is necessary for people who want to build custom packages and use a Debian testing environment, as Date::ICal is no longer there.
Comment 7 Paul Poulain 2012-02-17 10:49:43 UTC
Introduce a new dependancy, definetly something for 3.8 and not 3.6
Comment 8 Jared Camins-Esakov 2012-12-31 00:38:46 UTC
There have been no further reports of problems so I am marking this bug resolved.