|
Description
Nicole C. Engard
2012-02-15 20:26:21 UTC
I had one of our partners report this as an issue today. Created attachment 31000 [details]
Cart, sorted by "Items" then printed using the browser's "Print" option (Control-P)
Created attachment 31001 [details]
Same cart, sorted identically, but printed using the koha print button.
Note that the issue occurs in both OPAC and Staff Client. Hi, I wonder if someone is working on the problem. It still persists in version 17.05 of Koha. Thanks, Patrick. Updating to be a bug. Created attachment 76246 [details] [review] Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. This seems to work well, but I want to check the other changed pages still. Something I notices on the printout is that the printing runs into the footers/headers in Firefox and there is only very little to no margin on the left and right. Not sure if we can do something about this, seems similar with the existing print feature. Created attachment 76418 [details] [review] Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 76491 [details] [review] Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 76492 [details] [review] Bug 7547: (QA follow-up) Make button background transparent for consistency Test plan: Add some records to cart in opac and show the cart, look at the print button/link --> without patch it has darker background than other buttons --> with this patch it has the same background Note: tested wir firefox 45, firefox 60 and chromium 66 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 76623 [details] [review] Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 76624 [details] [review] Bug 7547: (QA follow-up) Make button background transparent for consistency Test plan: Add some records to cart in opac and show the cart, look at the print button/link --> without patch it has darker background than other buttons --> with this patch it has the same background Note: tested wir firefox 45, firefox 60 and chromium 66 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 76625 [details] [review] Bug 7547: (RM follow-up) Compiled css Awesome work all! Pushed to master for 18.11 Enhancement, not porting to 18.05.x series. Since these patches the "Column visibility" button is displayed at the OPAC: https://screenshots.firefox.com/OEOzq6a0aEozv8rU/catalogue.kohadev.org It should not. (In reply to Jonathan Druart from comment #17) > Since these patches the "Column visibility" button is displayed at the OPAC: > https://screenshots.firefox.com/OEOzq6a0aEozv8rU/catalogue.kohadev.org > > It should not. True, I filled a new Bug 21145 for this |