See Bug 7547 Comment 17
Created attachment 77422 [details] [review] Bug 21145: Do not show buttons for datatables on opac detail page Test plan: 0) Do not apply the patch 1) Go to opac detail page 2) There are up to three datatables - items - items from other branches (only if there are any and the OpacSeparateHoldings preference is set) - subscriptions 3) try to find record with all three tables and confirm, there is button "Columns visibility" above the table 4) Apply the patch 5) Repeat 1-3 and confirm the button is no more here
Josef, this 'B' has not been added by 7547, did you understand why it comes from it?
Bug 16759 - Make OPAC holdings table configurable It would be nice if we could make it so that if all columns were marked "Cannot be toggled" in Administration->Columns configuration, the column visibility button wouldn't appear. I'd say this bug should either be repurposed for that goal or marked invalid.
There is an ergonomic issue: https://screenshots.firefox.com/Boc5Au4AfMnN9O1F/catalogue.kohadev.org It is fixed by this patch and restore the behavior pre-bug 7547. IMO we should have it as it and then see if it needs to be improved.
(In reply to Owen Leonard from comment #3) > Bug 16759 - Make OPAC holdings table configurable Sorry, I misunderstood the root of the problem. Bug 16759 didn't seek to add the columns configuration button.
Created attachment 77456 [details] [review] Bug 21145: Do not show buttons for datatables on opac detail page Test plan: 0) Do not apply the patch 1) Go to opac detail page 2) There are up to three datatables - items - items from other branches (only if there are any and the OpacSeparateHoldings preference is set) - subscriptions 3) try to find record with all three tables and confirm, there is button "Columns visibility" above the table 4) Apply the patch 5) Repeat 1-3 and confirm the button is no more here Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Bug 16759 added the "B" dom configuration, but didn't add the corresponding button plugin. When Bug 7547 updated DataTables to include the button plugin the button appeared.
Created attachment 77458 [details] [review] Bug 21145: Do not show buttons for datatables on opac detail page Test plan: 0) Do not apply the patch 1) Go to opac detail page 2) There are up to three datatables - items - items from other branches (only if there are any and the OpacSeparateHoldings preference is set) - subscriptions 3) try to find record with all three tables and confirm, there is button "Columns visibility" above the table 4) Apply the patch 5) Repeat 1-3 and confirm the button is no more here Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thank you both for so quick testing!
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Depends on Bug 7547 not in 17.11.x