Description
Katrin Fischer
2012-03-20 15:13:26 UTC
Created attachment 8364 [details] [review] Bug 7760: Add unique ids and a module class to all acquisitions pages This is the first patch for bug 7760 and touches all pages in acquisitions. This adds the file name as unique id and a class 'acq' to the body tag. Created attachment 8366 [details] [review] Bug 7760: Add unique ids and a module class to all acquisitions pages This is the first patch for bug 7760 and touches all pages in acquisitions. This adds a unique id "acq_<filename>" and a class "acq" to the body tag of each page in acquisitions. Created attachment 8367 [details] [review] Bug 7760: Add unique ids and a module class to all authorities pages This is the first patch for bug 7760 and touches all pages in authorities. This adds a unique id "auth_<filename>" and a class "auth" to the body tag of each page in the authorities module. Created attachment 8368 [details] [review] [SIGNED OFF] Bug 7760: Add unique ids and a module class to all acquisitions pages Created attachment 8374 [details] [review] Bug 7760: Add unique ids and a module class to all administration pages This is the first patch for bug 7760 and touches all pages in administration. This adds a unique id "admin_<filename>" and a class "admin" to the body tag of each page in administration. Note: aqcontract can only be accessed from the acquisition module, so I made it acq instead of admin. Created attachment 8401 [details] [review] [SIGNED OFF] Bug 7760: Add unique ids and a module class to all authorities pages Created attachment 8402 [details] [review] [SIGNED OFF] Bug 7760: Add unique ids and a module class to all administration pages Created attachment 8432 [details] [review] Bug 7760: Add ids and classes to every staff page to help with customizaton (cart) id = cart_<filename> class = cart Created attachment 8433 [details] [review] Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error) Created attachment 8434 [details] [review] Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error) Created attachment 8448 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customizaton (catalog) Created attachment 8450 [details] [review] [SIGNED-OFF] Bug 7760: Add ids and classes to every staff page to help with customizaton (cart) id = cart_<filename> class = cart Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8456 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customizaton (cataloguing) New ids: cat_<filename> New class: cat Exceptions: moveitem and linkitem are accessible from the catalog pages, so have been made 'catalog' for styling. Created attachment 8457 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customizaton (circulation) New id: circ_<filename> New class: circ Created attachment 8479 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customizaton (lists, suggestion, z39.50) Created attachment 8480 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customization (patrons) Class is 'pat' and ids start with 'pat_'. Created attachment 8482 [details] [review] Add ids and classes to every staff page to help with customization (serials) Created attachment 8484 [details] [review] [SIGNED-OFF] Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8486 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customization (tools) Prefix for ids and class is 'tools' Created attachment 8487 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customizaton (catalog) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8491 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customizaton (cataloguing) New ids: cat_<filename> New class: cat Exceptions: moveitem and linkitem are accessible from the catalog pages, so have been made 'catalog' for styling. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8492 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customization (patroncard, labels) After talking to Owen we decided to use 2 classes for those modules. I decided on: patroncard: tools, pcard labels: tools, labels Created attachment 8493 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customizaton (circulation) New id: circ_<filename> New class: circ Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8495 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customizaton (lists, suggestion, z39.50) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8496 [details] [review] Bug 7760 - Add ids and classes to every staff page to help with customization (reports, ...) This is the last one - adding the classes and ids to the report module and some template files for smaller moduls/functions. Created attachment 8500 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customization (patrons) Class is 'pat' and ids start with 'pat_'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8508 [details] [review] [SIGNED-OFF] Add ids and classes to every staff page to help with customization (serials) http://bugs.koha-community.org/show_bug.cgi?id=7760 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8515 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customization (tools) Prefix for ids and class is 'tools' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8517 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customization (patroncard, labels) After talking to Owen we decided to use 2 classes for those modules. I decided on: patroncard: tools, pcard labels: tools, labels Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 8518 [details] [review] [SIGNED-OFF] Bug 7760 - Add ids and classes to every staff page to help with customization (reports, ...) This is the last one - adding the classes and ids to the report module and some template files for smaller moduls/functions. Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment : template only changes, just add ids to each body. valid_template test still OK passed QA Here's a quick example showing how one might begin to add colors based on these patches. This snippet of CSS adds colors to the header menu and the breadcrumbs, specific to circulation functions: /* Circulation */ body.circ #header, body.circ #breadcrumbs { background-color: #8189D1; border-bottom: 1px solid #484E82; } body.circ #header a, body.circ #breadcrumbs a { color: #FFFFFF; font-weight: bold; } body.circ #header, body.circ #breadcrumbs { color : #DDDDDD; } body.circ #moremenu a { color : #8189D1; } You would then create different declarations for each section you wanted to make distinct. The new classes: acq (acquisitions) admin (administration) auth (authorities) batch (batch/print-notices.tt) catalog (catalog) cart (cart) cat (cataloging) circ (circulation) err (errors) lists (lists) pat (patrons) rep (reports) ser (serials) tools (tools) - "tools" pages with multiple sub-pages get two classes, tools + their own class: labels (labels) pcard (patron cards) rcoll (rolling collections) - "tools" pages which consist of a single page have only the "tools" class and, like every other page, their own unique ID. e.g. <body id="tools_holidays" class="tools"> More <div>s will have to be added in the future to increase customization options futher. For instance, the space between the header menu at the top of the page and the breadcrumbs is not contained within a single <div> which would allow customization of the background between those elements. It's also not possible to assign specific CSS to the main body of the page (everything between breadcrumbs and the language menu footer). New bugs reports should cover these changes. P.S. If anyone wants to build a web-based tool to automatically generate a full color scheme based on the user's color picks please do so :) adding gaetan to cc list of this bug Created attachment 8554 [details] [review] Bug 7760: More ids and classes for the staff interface Owen pointed out that I missed 3 files - this corrects my omission. Also note that you can add this can easily be achieved by putting owen's code into IntranetUserCSS syspref (just tested it work well: it does) Created attachment 8565 [details] [review] [SIGNED-OFF] Bug 7760: More ids and classes for the staff interface Owen pointed out that I missed 3 files - this corrects my omission. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I have filed Bug 7812 describing the next set of markup changes I think we need. All these patches are solid, consistent and on-topic. All of them are now marked Passed QA. I obsoleted the pushed patches -only 1 is missing from master now. everything pushed now This bug will be included in the Koha 3.6.5 release. This bug will be included in the Koha 3.6.5 release. |