Summary: | Warnings in logs for search.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
Component: | Searching | Assignee: | Adrien SAURAT <adrien.saurat> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | minor | ||
Priority: | P5 - low | CC: | m.de.rooy, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7786 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed patch #1
Amended patch Amended patch Followup for opac side Amended patch Followup for opac |
Description
Adrien SAURAT
2012-04-02 10:11:12 UTC
Created attachment 8757 [details] [review] proposed patch #1 Created attachment 8758 [details]
Amended patch
Comment on attachment 8758 [details]
Amended patch
Wrong file
Created attachment 8759 [details] [review] Amended patch Created attachment 8760 [details] [review] Followup for opac side Makes the same change in opac template This report fixes bug introduced by 7786 not checking if addbarshelvesloop or addpubshelvesloop were actually defined. Patch for staff and a patch for opac. I amended the patch of Adrien in order to cover the situation that addbarshelves does not exist but addpubshelves does exist. Created attachment 8763 [details] [review] Amended patch Second correction of wrong file Created attachment 8764 [details] [review] Followup for opac Tested both patches in opac results and staff results by removing all private lists. Without patches warnings in opac and staff. With patches no warnings in opac and staff. Status to Signed off. Didn't notice the OPAC impact, thanks. Both patches simply add a check for the existence of the variable before doing a comparison on it. Marking Passed QA for both. There have been no further reports of problems so I am marking this bug resolved. |