Bug 7868 - Warnings in logs for search.pl
Summary: Warnings in logs for search.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Adrien SAURAT
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 10:11 UTC by Adrien SAURAT
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch #1 (1.54 KB, patch)
2012-04-02 10:33 UTC, Adrien SAURAT
Details | Diff | Splinter Review
Amended patch (1.75 KB, text/plain)
2012-04-02 10:47 UTC, Marcel de Rooy
Details
Amended patch (1.72 KB, patch)
2012-04-02 10:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Followup for opac side (1.36 KB, patch)
2012-04-02 10:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Amended patch (1.59 KB, patch)
2012-04-02 11:03 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Followup for opac (1.47 KB, patch)
2012-04-02 11:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien SAURAT 2012-04-02 10:11:12 UTC
When doing a search from the intranet, we get warnings in the logs like :

Argument "" isn't numeric in numeric gt (>) at /home/asaurat/workspace/versions/community/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt line 75., referer: http://admin.community.localhost/cgi-bin/koha/catalogue/search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&sort_by=relevancea
Comment 1 Adrien SAURAT 2012-04-02 10:33:18 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2012-04-02 10:47:37 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2012-04-02 10:48:08 UTC
Comment on attachment 8758 [details]
Amended patch

Wrong file
Comment 4 Marcel de Rooy 2012-04-02 10:49:48 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2012-04-02 10:57:19 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2012-04-02 10:59:46 UTC
This report fixes bug introduced by 7786 not checking if addbarshelvesloop or addpubshelvesloop were actually defined.
Patch for staff and a patch for opac.

I amended the patch of Adrien in order to cover the situation that addbarshelves does not exist but addpubshelves does exist.
Comment 7 Marcel de Rooy 2012-04-02 11:03:39 UTC
Created attachment 8763 [details] [review]
Amended patch

Second correction of wrong file
Comment 8 Marcel de Rooy 2012-04-02 11:32:37 UTC
Created attachment 8764 [details] [review]
Followup for opac

Tested both patches in opac results and staff results by removing all private lists. Without patches warnings in opac and staff. With patches no warnings in opac and staff.
Status to Signed off.
Comment 9 Adrien SAURAT 2012-04-02 11:54:05 UTC
Didn't notice the OPAC impact, thanks.
Comment 10 Ian Walls 2012-04-03 15:24:32 UTC
Both patches simply add a check for the existence of the variable before doing a comparison on it.  Marking Passed QA for both.
Comment 11 Jared Camins-Esakov 2012-12-31 00:50:07 UTC
There have been no further reports of problems so I am marking this bug resolved.