| Summary: | Remove C4::Dates from C4::Circulation | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
| Component: | Architecture, internals, and plumbing | Assignee: | Galen Charlton <gmcharlt> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Now that we have Koha::Calendar and DateTime, we no longer need C4::Dates in C4::Circulation There are currently 6 usages of the module left: 2 'use' calls to this... both will be removed. 2 calls to format_date in CanBookBeIssued (needsconfirmation message). Will need to replace with KohaDates plugin on all template pages using this subroutine "if (C4::Context->preference('globalDueDate') && (C4::Context->preference('globalDueDate') =~ C4::Dates->regexp('syspref')" is never true since that syspref was removed, so it can be removed entirely sub TransferSlip creates a new $pulldate variable, but never uses it before the subroutine exits. Can be removed The rest of the usage here is in the POD, which needs to be updated to reflect the new type of objects we're using now with Hourly Loans.