| Summary: | Update OPAC suggestions interface to match lists | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | jonathan.druart, nengard, paul.poulain |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 7959 - Update OPAC suggestions interface to match lists
[SIGNED-OFF] Bug 7953 - add opacuserjs to the sco template [SIGNED-OFF] Bug 7959 - Update OPAC suggestions interface to match lists Bug 7959 - Update OPAC suggestions interface to match lists |
||
|
Description
Owen Leonard
2012-04-13 19:20:29 UTC
Created attachment 9188 [details] [review] Bug 7959 - Update OPAC suggestions interface to match lists Marking up suggestions "toolbar" to match the interface in lists. Actions which require an item to be selected (deleting a suggestion) should not be available if nothing is selected. Created attachment 9369 [details] [review] [SIGNED-OFF] Bug 7953 - add opacuserjs to the sco template To test: add some jquery to opacuserjs that would change the screen a la: $(".checkout label[for='patronid']").css("border","3px solid red"); verify you see a red box on the sco-main page. Also adds the ability to use opacusercss to style sco-main.tt to test: Add some css to opacusercss that would change the screen: .checkout { background: grey; } verify you see a grey box around the checkout div. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Sorry, git bz typo. Created attachment 9454 [details] [review] [SIGNED-OFF] Bug 7959 - Update OPAC suggestions interface to match lists Marking up suggestions "toolbar" to match the interface in lists. Actions which require an item to be selected (deleting a suggestion) should not be available if nothing is selected. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Hi Owen,
Is there a reason to use double quote instead of simple quote in your html replacement ?
I think:
$("span.checkall").html("<a id=\"CheckAll\" href=\"#\">"+_('Select all')+"<\/a>");
is not easier to read than:
$("span.checkall").html('<a id="CheckAll" href="#">'+_('Select all')+'</a>');
(In reply to comment #5) > Is there a reason to use double quote instead of simple quote in your html > replacement ? I agree about the readability, but I also like the consistency of always using a double quote when I start typing something like .html() knowing that I can escape any quotes I'll need later. I'd be happy to agree to either pattern and set a coding guideline for it. The patch does not apply, CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt I feel it's not hard to fix, but I don't want to do a mistake, so please rebase & resubmit Created attachment 9708 [details] [review] Bug 7959 - Update OPAC suggestions interface to match lists Rebased against current master QA comment: template change only, passes tests for validity/translatability passed QA There have been no further reports of problems so I am marking this bug resolved. |