Summary: | CircAutoPrintQuickSlip set to clear doesn't work | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Circulation | Assignee: | Srdjan Jankovic <srdjan> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P5 - low | CC: | chris, gmcharlt, julian.maurice, koha.sekjal, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
patch
[SIGNED-OFF] bug_8056: sorted out slip print calls patch patch [SIGNED-OFF] bug_8056: sorted out slip print calls |
Description
Nicole C. Engard
2012-05-07 15:08:43 UTC
Created attachment 9468 [details] [review] patch Created attachment 9472 [details] [review] [SIGNED-OFF] bug_8056: sorted out slip print calls Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Breaks Plack scoping fix for our $todaysdate, throwing it back to 'my'. Marking Failed QA. Created attachment 9506 [details] [review] patch Well it was an unsolicited change, I'm sorry. However, whatever problem was solved by changing that "my" "our" should be revisited, that is usually more of a hack than a good solution. I don't know if this file is used, but t/db_dependent/lib/KohaTest/Print.pm contains: my @methods = qw( printslip ); and the patch remove this sub, so I think this file should be modified too. Created attachment 9549 [details] [review] patch Good catch, corrected. Created attachment 9557 [details] [review] [SIGNED-OFF] bug_8056: sorted out slip print calls Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> preference works as expected. QA comment: * remove more code than it adds. Good point ;-) * clean code, passes perlcritic (remove 1 perlcritic problem. 2 still here, but were here before the patch) passed QA No database changes, fixes a regression, pushed to 3.8.x will be in 3.8.x |