Bug 8056 - CircAutoPrintQuickSlip set to clear doesn't work
Summary: CircAutoPrintQuickSlip set to clear doesn't work
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low critical (vote)
Assignee: Srdjan Jankovic
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 15:08 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch (2.98 KB, patch)
2012-05-09 02:52 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
[SIGNED-OFF] bug_8056: sorted out slip print calls (3.05 KB, patch)
2012-05-09 14:08 UTC, Nicole C. Engard
Details | Diff | Splinter Review
patch (2.74 KB, patch)
2012-05-11 02:25 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
patch (3.84 KB, patch)
2012-05-14 03:19 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
[SIGNED-OFF] bug_8056: sorted out slip print calls (3.94 KB, patch)
2012-05-14 11:54 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-05-07 15:08:43 UTC
I have CircAutoPrintQuickSlip set to clear the screen but when I enter a blank barcode I get the following error:


Software error:

Undefined subroutine &main::PrintIssueSlip called at /home/nengard/kohaclone/circ/circulation.pl line 175.
Comment 1 Srdjan Jankovic 2012-05-09 02:52:15 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2012-05-09 14:08:30 UTC Comment hidden (obsolete)
Comment 3 Ian Walls 2012-05-10 16:11:01 UTC
Breaks Plack scoping fix for our $todaysdate, throwing it back to 'my'.

Marking Failed QA.
Comment 4 Srdjan Jankovic 2012-05-11 02:25:55 UTC Comment hidden (obsolete)
Comment 5 Julian Maurice 2012-05-11 11:52:03 UTC
I don't know if this file is used, but t/db_dependent/lib/KohaTest/Print.pm contains:

    my @methods = qw( printslip );

and the patch remove this sub, so I think this file should be modified too.
Comment 6 Srdjan Jankovic 2012-05-14 03:19:54 UTC Comment hidden (obsolete)
Comment 7 Nicole C. Engard 2012-05-14 11:54:42 UTC
Created attachment 9557 [details] [review]
[SIGNED-OFF] bug_8056: sorted out slip print calls

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
preference works as expected.
Comment 8 Paul Poulain 2012-05-28 11:56:39 UTC
QA comment:
* remove more code than it adds. Good point ;-)
* clean code, passes perlcritic (remove 1 perlcritic problem. 2 still here, but were here before the patch)

passed QA
Comment 9 Chris Cormack 2012-05-28 20:58:21 UTC
No database changes, fixes a regression, pushed to 3.8.x will be in 3.8.x